New feature: terraform target by tags #685
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbkok
requested changes
Jan 18, 2024
...ebase/initial_commit/bootstrap_repository/adf-build/shared/helpers/terraform/get_accounts.py
Outdated
Show resolved
Hide resolved
...ebase/initial_commit/bootstrap_repository/adf-build/shared/helpers/terraform/get_accounts.py
Outdated
Show resolved
Hide resolved
...ebase/initial_commit/bootstrap_repository/adf-build/shared/helpers/terraform/get_accounts.py
Outdated
Show resolved
Hide resolved
sbkok
requested changes
Oct 24, 2024
| All filter clauses are applied with logical AND, all values in a single clause are applied with logical OR | ||
|
|
||
| **Eg:** `TARGET_TAGS=Name=environment,Values=prd,dev;Name=cost-center,Values=ccoe` will match all | ||
| accounts tagged with `environment=prd` OR `environment=dev` AND `cost-center = ccoe` |
There was a problem hiding this comment.
Suggested change
| accounts tagged with `environment=prd` OR `environment=dev` AND `cost-center = ccoe` | |
| accounts tagged with (`environment=prd` OR `environment=dev`) AND `cost-center=ccoe` |
| tag_filters | ||
| ) | ||
| organization_api_region = get_organization_api_region(REGION_DEFAULT) | ||
| print(organization_api_region) |
There was a problem hiding this comment.
Suggested change
| print(organization_api_region) |
| tag_values = tags.split(",", 1)[1].split("=")[1].split(",") | ||
| tag_filters.append({ | ||
| "Key": tag_name, | ||
| "Values": tag_values}) |
There was a problem hiding this comment.
Suggested change
| "Values": tag_values}) | |
| "Values": tag_values, | |
| }) |
| 'resourcegroupstaggingapi', | ||
| ( | ||
| f'arn:{PARTITION}:sts::{MANAGEMENT_ACCOUNT_ID}:role/' | ||
| f'{CROSS_ACCOUNT_ACCESS_ROLE}-readonly' |
There was a problem hiding this comment.
This will need to be updated to the new role added in v4.
| REGION_DEFAULT = os.environ["AWS_REGION"] | ||
| PARTITION = get_partition(REGION_DEFAULT) | ||
| sts = boto3.client('sts') | ||
| ssm = boto3.client('ssm') | ||
| organizations = boto3.client('organizations') |
There was a problem hiding this comment.
Could you change this to include a higher retry count?
Otherwise it might run into the rate limitation of the AWS Organizations API and fail.
This would be likely if multiple Terraform pipelines would run concurrently.
An example how to change it: https://github.com/awslabs/aws-deployment-framework/pull/774/files#diff-05a19c0ecc528b81f98611295fccbb53ec8ce9f20937f67308f3bc886e4a5018R83-R89
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
With this new feature, terraform helper is able to target accounts matching a tag expressed as key=value. You can define multiple tags and all accounts matching at least one of the tags will become target of the pipeline.
What?
Description of changes:
get_accounts.pyorganizations:ListTagsForResourcepermission toadf-organizations-readonly-policyso that the pipeline role is able to fetch tag informationBy submitting this pull request, I confirm that you can use, modify, copy, and
redistribute this contribution, under the terms of your choice.