Compile device client binaries as Release build type #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RogerZhongAWS
approved these changes
Aug 2, 2023
HarshGandhi-AWS
approved these changes
Aug 2, 2023
HarshGandhi-AWS
added a commit
that referenced
this pull request
Dec 20, 2023
* Updated SDK commit to use the latest SDK code * Addressed reviewers comments and updated unit tests to support the change * Resolved indentation errors * Resolved indentation errors * Resolved indentation errors * Resolved indentation errors * Resolved indentation errors * update device mqtt connection logic * removing DC initialization code to create multiple lock files * addressed reviewers comments to resolve test failures * resolved unit test failure * remove MemoryTrace unit test * resolved Lint errors * explicitly calling the code in SharedCrtManager to initialize allocator and api handle. This will resolve the Sensor pullish unit tests which manually creates and initializes allocator and eventloop. * addressed lint errors * addressed lint errors * addressed reviewers comment and added the config serialization test back * Update GTestMain.cpp to not cleanup resources after testing is completed This change will be reverted later. Added this to investigate DD integ test failure * Update e2e-tests-ubutu-x86 test to skip secure tunneling test * Compile device client binaries as Release build type (#422) * update sdk commit again * Updated code to shutdown on tunnel close callback and updated zlib dependency version(#426) * updated code to shutdown on tunnel close callback * addressed lint errors * addressed lint errors * addressed lint errors * updated zlib version * updated zlib version * updated comment * Updated Secure Tunneling close logic for Secure Tunneling Component (#427) * Updated tunnel shutdown logic for Secure Tunneling component * removed extra log statement * Added null check before closing connection (#429) * fixed bug to read SIGTERM signal when sent form kernal (#430) * Fix docker-build.sh (#423) There is an additional level of indirection required for the script to be able to build the container. Co-authored-by: Miguel Cano <[email protected]> * Updated google-test lib version to v1.12.0 (#431) * disabled jobs and secure tunneling if they are not compiled into binary (#436) * Update Dockerfile OpenSSL version (#435) * Update Dockerfile * Update README.md * Removed number of slash validation for MQTT topics (#438) * conflict fix * add http proxy support for secure tunneling * cleanup http proxy changes * fix format * fix format --------- Co-authored-by: marco morais <[email protected]> Co-authored-by: RogerZhongAWS <[email protected]> Co-authored-by: RogerZhongAWS <[email protected]> Co-authored-by: Miguel Cano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Debugbuild which results in a binary size of 32M in comparison to theReleasebuild which produces a binary of 6M.Modifications
Change summary
Modify the release type of the device client builds used in Dockerfile from
DebugtoRelaseRevision diff summary
If there is more than one revision, please explain what has been changed since the last revision.
Testing
32M binary compiled using
Debug—cmake -DCMAKE_VERBOSE_MAKEFILE:BOOL=ON -DCMAKE_BUILD_TYPE=Debug .. && cmake --build . --target aws-iot-device-client6M binary compiled using
Release—cmake -DCMAKE_VERBOSE_MAKEFILE:BOOL=ON -DCMAKE_BUILD_TYPE=Release .. && cmake --build . --target aws-iot-device-clientBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.