-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve search integration with the documentation panel #185
base: master
Are you sure you want to change the base?
Conversation
Trying to write tests for this by leveraging the internal interfaces will be quite challenging. I also found hecate (by the same guy who wrote hypothesis) which is a testing framework designed for testing ncurses like terminal applications. It leverages tmux as a terminal emulator and interfaces with a tmux session to send input and determine the current screen state. It's relatively simple to write tests with it and I have one in this PR to test these changes. Unfortunately, actually running an instance of the shell to run tests against it currently is being blocked by having the documentation generate in the background. It would be better to have all the documentation already generated then run these kind of integration tests against them for consistency. |
21ace53
to
ff4c8d3
Compare
I got a proof of concept done for the This approach has some pretty significant advantages over
|
ff4c8d3
to
25645ff
Compare
Previously, if you hit the input timeout while searching the documentation panel would close as input into the search buffer would be taken into consideration for the documentation to be shown. This PR does two things: