Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MetricsRepository using Spark tables as the data source #518

Merged
merged 2 commits into from
Nov 28, 2023
Merged

MetricsRepository using Spark tables as the data source #518

merged 2 commits into from
Nov 28, 2023

Conversation

VenkataKarthikP
Copy link
Contributor

@VenkataKarthikP VenkataKarthikP commented Oct 30, 2023 •
edited
Loading

Issue #, if available:
#502
Description of changes:
An implementation of MetricsRepository using Spark tables as the data source.

Currently, DQ heavily relies on spark for processing. But to save metrics to a table like Iceberg or Hive or other spark catalog based, we don't have an implementation. With this PR, users can save metrics to a table and read them offline as needed.

Example usage -

val spark = <your spark session>
val repository = new SparkTableMetricsRepository(spark, "metrics_table")

repository.save(resultKey, context)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rdsharma26
Copy link
Contributor

Hi @VenkataKarthikP, thank you for the PR! While we review the PR, could you please provide more details on the use case that this PR helps enable? An example snippet of code of how this feature can be used will be great, to both serve as motivation for the PR and for documentation going forward.

@VenkataKarthikP
Copy link
Contributor Author

Hi @VenkataKarthikP, thank you for the PR! While we review the PR, could you please provide more details on the use case that this PR helps enable? An example snippet of code of how this feature can be used will be great, to both serve as motivation for the PR and for documentation going forward.

@rdsharma26 updated PR description with more details, let me know if it looks good.

@VenkataKarthikP VenkataKarthikP mentioned this pull request Nov 3, 2023
Open
rdsharma26
rdsharma26 reviewed Nov 9, 2023
View reviewed changes
src/main/scala/com/amazon/deequ/repository/sparktable/SparkMetricsRepository.scala Outdated Show resolved Hide resolved
src/main/scala/com/amazon/deequ/repository/sparktable/SparkMetricsRepository.scala Outdated Show resolved Hide resolved
src/main/scala/com/amazon/deequ/repository/sparktable/SparkMetricsRepository.scala Outdated Show resolved Hide resolved
src/main/scala/com/amazon/deequ/repository/sparktable/SparkMetricsRepository.scala Outdated Show resolved Hide resolved
src/main/scala/com/amazon/deequ/repository/sparktable/SparkMetricsRepository.scala Show resolved Hide resolved
src/main/scala/com/amazon/deequ/repository/sparktable/SparkMetricsRepository.scala Outdated Show resolved Hide resolved
src/test/scala/com/amazon/deequ/SparkContextSpec.scala Outdated Show resolved Hide resolved
src/main/scala/com/amazon/deequ/repository/sparktable/SparkMetricsRepository.scala Outdated Show resolved Hide resolved
src/test/scala/com/amazon/deequ/repository/sparktable/SparkTableMetricsRepositoryTest.scala Outdated Show resolved Hide resolved
pom.xml Show resolved Hide resolved
@VenkataKarthikP
Copy link
Contributor Author

@rdsharma26 thanks for review, have addressed review comments, with some follow up questions.

SirWerto
SirWerto reviewed Nov 14, 2023
View reviewed changes
src/main/scala/com/amazon/deequ/repository/sparktable/SparkMetricsRepository.scala
Comment on lines +40 to +42
metricDF.write
.mode(SaveMode.Append)
.saveAsTable(tableName)
Copy link

@SirWerto SirWerto Nov 14, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @VenkataKarthikP, thanks a lot for the added feature!!!

Could we consider to let the user define the write options in some way?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, I think it's great idea. let me check!

@VenkataKarthikP
Copy link
Contributor Author

@rdsharma26 can we merge this PR. thanks

@rdsharma26 rdsharma26 merged commit 1fc09e1 into awslabs:master Nov 28, 2023
1 check passed
eycho-am pushed a commit that referenced this pull request Feb 21, 2024
@VenkataKarthikP @eycho-am
MetricsRepository using Spark tables as the data source (#518)
57c193d 
* spark table repository

* review comments

---------

Co-authored-by: vpenikalapati <[email protected]>
eycho-am pushed a commit that referenced this pull request Feb 21, 2024
@VenkataKarthikP @eycho-am
MetricsRepository using Spark tables as the data source (#518)
bdcbeda 
* spark table repository

* review comments

---------

Co-authored-by: vpenikalapati <[email protected]>
@eycho-am eycho-am mentioned this pull request Feb 21, 2024
Merged
rdsharma26 pushed a commit that referenced this pull request Apr 16, 2024
@VenkataKarthikP @rdsharma26
MetricsRepository using Spark tables as the data source (#518)
e8781a3 
* spark table repository

* review comments

---------

Co-authored-by: vpenikalapati <[email protected]>
rdsharma26 pushed a commit that referenced this pull request Apr 16, 2024
@VenkataKarthikP @rdsharma26
MetricsRepository using Spark tables as the data source (#518)
717f7fc 
* spark table repository

* review comments

---------

Co-authored-by: vpenikalapati <[email protected]>
rdsharma26 pushed a commit that referenced this pull request Apr 16, 2024
@VenkataKarthikP @rdsharma26
MetricsRepository using Spark tables as the data source (#518)
5126084 
* spark table repository

* review comments

---------

Co-authored-by: vpenikalapati <[email protected]>
rdsharma26 pushed a commit that referenced this pull request Apr 17, 2024
@VenkataKarthikP @rdsharma26
MetricsRepository using Spark tables as the data source (#518)
f20c1f8 
* spark table repository

* review comments

---------

Co-authored-by: vpenikalapati <[email protected]>
rdsharma26 pushed a commit that referenced this pull request Apr 17, 2024
@VenkataKarthikP @rdsharma26
MetricsRepository using Spark tables as the data source (#518)
23b92ec 
* spark table repository

* review comments

---------

Co-authored-by: vpenikalapati <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SirWerto SirWerto SirWerto left review comments

@rdsharma26 rdsharma26 rdsharma26 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VenkataKarthikP @rdsharma26 @SirWerto