fix: GitHub workflows (#14)

* fix strings in workflows * add missing condition on workflow * chore: self mutation Signed-off-by: github-actions <[email protected]> * test to change condition for workflow * test to remove repository condition * add exempt contributor --------- Signed-off-by: github-actions <[email protected]> Co-authored-by: github-actions <[email protected]>
awslabs · Oct 5, 2023 · 9f422fe · 9f422fe
1 parent 1edfd27
commit 9f422fe
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 10 deletions.
diff --git a/.github/workflows/auto-approve.yml b/.github/workflows/auto-approve.yml
diff --git a/.github/workflows/github-merit-badger.yml b/.github/workflows/github-merit-badger.yml
diff --git a/.github/workflows/monthly-repo-metrics.yml b/.github/workflows/monthly-repo-metrics.yml
diff --git a/.github/workflows/update-contributors.yml b/.github/workflows/update-contributors.yml
diff --git a/projenrc/github-workflows.ts b/projenrc/github-workflows.ts
@@ -34,7 +34,7 @@ export function buildMeritBadgerWorkflow(project: AwsCdkConstructLibrary) {
           'github-token': '${{ secrets.PROJEN_GITHUB_TOKEN }}',
           'badges': '[beginning-contributor,repeat-contributor,valued-contributor,admired-contributor,star-contributor,distinguished-contributor]',
           'thresholds': '[0,3,6,13,25,50]',
-          'ignore-usernames': '[emerging-tech-cdk-constructs-bot, dependabot[bot], amazon-auto, github-actions]',
+          'ignore-usernames': '[emerging-tech-cdk-constructs-bot, dependabot[bot], dependabot, amazon-auto, github-actions]',
         },
       },
     ],
@@ -66,7 +66,7 @@ export function buildMonthlyIssuesMetricsWorkflow(project: AwsCdkConstructLibrar
       issues: JobPermission.WRITE,
       pullRequests: JobPermission.READ,
     },
-    if: 'github.repository == aws-samples/emerging-tech-cdk-constructs',
+    if: "github.repository == 'aws-samples/emerging-tech-cdk-constructs'",
     runsOn: ['ubuntu-latest'],
     name: 'metrics',
     steps: [
@@ -152,7 +152,7 @@ export function buildUpdateContributorsWorkflow(project: AwsCdkConstructLibrary)
     permissions: {
       pullRequests: JobPermission.WRITE,
     },
-    if: 'github.repository == aws-samples/emerging-tech-cdk-constructs',
+    if: "github.repository == 'aws-samples/emerging-tech-cdk-constructs'",
     runsOn: ['ubuntu-latest'],
     steps: [
       {
@@ -165,7 +165,7 @@ export function buildUpdateContributorsWorkflow(project: AwsCdkConstructLibrary)
         {
           CONTRIB_REPOSITORY: 'aws-samples/emerging-tech-cdk-constructs',
           CONTRIB_OUTPUT_FILE: 'CONTRIBUTORS.md',
-          CONTRIB_IGNORE: 'emerging-tech-cdk-constructs-bot, dependabot[bot], amazon-auto, github-actions',
+          CONTRIB_IGNORE: 'emerging-tech-cdk-constructs-bot, dependabot[bot], dependabot, amazon-auto, github-actions',
         },
       },
       {
@@ -206,7 +206,7 @@ export function buildUpdateContributorsWorkflow(project: AwsCdkConstructLibrary)
 export function buildAutoApproveWorkflow(project: AwsCdkConstructLibrary) {
   const autoapprove: Job = {
     runsOn: ['ubuntu-latest'],
-    if: 'github.repository == aws-samples/emerging-tech-cdk-constructs && github.actor == emerging-tech-cdk-constructs-bot',
+    if: "(github.event.pull_request.user.login == 'emerging-tech-cdk-constructs-bot') && contains(github.event.pull_request.labels.*.name, 'auto-approve')",
     permissions: {
       pullRequests: JobPermission.WRITE,
     },