-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bedrock): add application inference profile #800
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krokoko
requested review from
MichaelWalker-git,
dineshSajwan and
alexa-perlov
November 13, 2024 23:07
scottschreckengaust
previously approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
aws-rafams
reviewed
Nov 15, 2024
aws-rafams
reviewed
Nov 15, 2024
aws-rafams
reviewed
Nov 15, 2024
aws-rafams
reviewed
Nov 15, 2024
aws-rafams
reviewed
Nov 15, 2024
Putting back to draft mode as other changes are done in a separate branch |
1 task
1 task
src/cdk-lib/bedrock/inference-profiles/cross-region-inference-profile.ts
Show resolved
Hide resolved
dineshSajwan
approved these changes
Nov 20, 2024
scottschreckengaust
approved these changes
Nov 20, 2024
MichaelWalker-git
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #683
Co-developed with @aws-rafams
Created 3 application inference profiles through CDK:
Example of CDK outputs:
Listed the available profiles through boto3:
Then used Converse API in Python to test the 3 created application inference profiles with
modelId=inf_profile_arn
Tested also with the Bedrock agent sample, by deploying the app with the existing model, and by using CRIS to ensure no regressions and support of the new features.
Tested to create prompts and test them through the console with CRIS
Remaining tasks:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.