Use -- when invoking grep during add_config
#240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes #62
Description of changes:
add_configinvokesgrepin two places to check for an existing identical pattern. This PR adds--before the pattern so thatgrepwon't interpret a pattern like "--foo" as an option.Also add a test for this functionality. Also improve the error propagation in add_config, so that
greperrors can be detected by tests.This change should probably also be applied to some (all?) other
grepandgit grepinvocations, but those are more complex cases without an outstanding bug report so I'm leaving them for now.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.