This repository has been archived by the owner on Oct 17, 2024. It is now read-only.
feat(schema): serverless http api cors configuration #485
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#403
Description of changes:
Fix CorsConfiguration for AWS::Serverless::HttpApi,
List
instead ofString
.AllowOrigins
notAllowOrigin
MaxAge
property isInteger
instead ofString
Note: Current definition seems to be the same as
CorsConfiguration for AWS::Serverless::Api
but they are incorrect.Ref:
HttpApiCorsConfiguration
https://docs.aws.amazon.com/serverless-application-model/latest/developerguide/sam-property-httpapi-httpapicorsconfiguration.html
Cors Configuration Object
https://github.com/aws/serverless-application-model/blob/master/versions/2016-10-31.md#cors-configuration-object
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.