Skip to content

Commit

Permalink
Address PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
muddyfish committed Dec 20, 2024
1 parent 22290ae commit a77b225
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/e2e-test-trusted.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@ jobs:
uses: ./.github/workflows/e2e-tests.yaml
with:
environment: "trusted"
ref: ${{ github.sha }}
ref: ${{ github.event_name == 'push' && github.sha || github.event.pull_request.head.sha }}
secrets: inherit
2 changes: 1 addition & 1 deletion .github/workflows/e2e-test-untrusted.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@ jobs:
uses: ./.github/workflows/e2e-tests.yaml
with:
environment: "untrusted"
ref: ${{ github.sha }}
ref: ${{ github.event.pull_request.head.sha }}
secrets: inherit
2 changes: 1 addition & 1 deletion .github/workflows/e2e-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ jobs:
env:
REGISTRY: ${{ steps.login-ecr.outputs.registry }}
PLATFORM: "linux/amd64,linux/arm64"
TAG: ${{ env.TAG_UNTESTED }}
TAG: "${{ env.TAG_UNTESTED }}"
run: |
make -j `nproc` all-push-skip-if-present
test:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
- name: Set up crane
uses: imjasonh/[email protected]

- name: Configure AWS Credentials from CI Trusted acccount
- name: Configure AWS Credentials from CI Trusted account
uses: aws-actions/configure-aws-credentials@v4
with:
role-to-assume: ${{ vars.CI_TRUSTED_IAM_ROLE }}
Expand Down Expand Up @@ -74,7 +74,7 @@ jobs:
SOURCE_REGISTRY: ${{ steps.login-ecr-trusted.outputs.registry }}
run: |
crane copy ${SOURCE_REGISTRY}/${IMAGE_NAME}:${TAG_PASSED} ${ARS_REGISTRY}:${GIT_TAG}
if [ -n "$VAR" ]; then
if [ -n "${PUBLIC_REGISTRY}" ]; then
crane copy ${SOURCE_REGISTRY}/${IMAGE_NAME}:${TAG_PASSED} ${PUBLIC_REGISTRY}:${GIT_TAG}
fi
Expand Down

0 comments on commit a77b225

Please sign in to comment.