Skip to content

Commit

Permalink
Use kubectl matching with cluster's version (#329)
Browse files Browse the repository at this point in the history
Currently, we use stable version of kubectl (v1.32 as of today), and
that might cause some problems as kubectl [emits a
warning](https://github.com/awslabs/mountpoint-s3-csi-driver/actions/runs/12561703668/job/35021134764#step:11:4567):
> WARNING: version difference between client (1.32) and server (1.29)
exceeds the supported minor version skew of +/-1

---
By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.

---------

Signed-off-by: Burak Varlı <[email protected]>
  • Loading branch information
unexge authored Jan 2, 2025
1 parent 1dc5e4d commit ee7f1ed
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions .github/workflows/e2e-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,7 @@ jobs:
- name: Install tools
run: |
export ACTION=install_tools
export K8S_VERSION=${{ matrix.kubernetes-version }}
tests/e2e-kubernetes/scripts/run.sh
- name: Run Controller Tests
run: |
Expand Down
4 changes: 2 additions & 2 deletions tests/e2e-kubernetes/scripts/run.sh
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,8 @@ mkdir -p ${BIN_DIR}
export PATH="$PATH:${BIN_DIR}"

function kubectl_install() {
curl -LO "https://dl.k8s.io/release/$(curl -L -s https://dl.k8s.io/release/stable.txt)/bin/linux/amd64/kubectl"
curl -LO "https://dl.k8s.io/release/$(curl -L -s https://dl.k8s.io/release/stable.txt)/bin/linux/amd64/kubectl.sha256"
curl -LO "https://dl.k8s.io/release/v$K8S_VERSION/bin/linux/amd64/kubectl"
curl -LO "https://dl.k8s.io/release/v$K8S_VERSION/bin/linux/amd64/kubectl.sha256"
echo "$(cat kubectl.sha256) kubectl" | sha256sum --check
sudo install -o root -g root -m 0755 kubectl ${KUBECTL_INSTALL_PATH}/kubectl
}
Expand Down

0 comments on commit ee7f1ed

Please sign in to comment.