-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add image-build action [WIP] #12
Conversation
push: | ||
# Sequence of patterns matched against refs/tags | ||
tags: | ||
- "v*" # Push events to matching v*, i.e. v1.0, v20.15.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we may need re-consider this, eventually we'll have to onboard to ARS and they'll distribute the ECR repo to all the regions for EKS add on, it may be "automated" if we use the latest tag, we need to sync with them about this process -- not a blocker comment just sharing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm interesting, so I tested this, it does not work out of the box, e.g. having 2 images in repo:
- s3-csi-driver-test:v0.0.1alpha
- s3-csi-driver-test:v0.0.2alpha
it does not automatically resolve latest
tag (I had a suspicion that it will):
Normal BackOff 8s kubelet Back-off pulling image "151381207180.dkr.ecr.eu-west-1.amazonaws.com/s3-csi-driver-test:latest"
but it seems like a feasible adjustment to tag image with the "greatest" v0.0.2
tag also as latest
at the end of this action (it will require some shell scripting and version parsing though)
- "v*" # Push events to matching v*, i.e. v1.0, v20.15.10 | ||
|
||
env: | ||
REGION : "us-east-1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
np: AWS_REGION
instead?
Image push / release process:
https://quip-amazon.com/oVYJA1EmXaJ4/S3-CSI-Driver-basic-CI#temp:C:SPK8c350dd1b54b4b35883dee91d