Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image-build action [WIP] #12

Merged
merged 11 commits into from
Oct 18, 2023
Merged

Add image-build action [WIP] #12

merged 11 commits into from
Oct 18, 2023

Conversation

vladem
Copy link
Contributor

@vladem vladem commented Oct 13, 2023

@vladem vladem temporarily deployed to PR Unit Tests October 13, 2023 14:55 — with GitHub Actions Inactive
@vladem vladem changed the title Add image-build action Add image-build action [WIP] Oct 13, 2023
@vladem vladem temporarily deployed to PR Unit Tests October 16, 2023 15:50 — with GitHub Actions Inactive
@vladem vladem changed the title Add image-build action [WIP] Add image-build action Oct 16, 2023
@vladem vladem temporarily deployed to PR Unit Tests October 16, 2023 16:23 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR Unit Tests October 16, 2023 16:41 — with GitHub Actions Inactive
@vladem vladem changed the title Add image-build action Add image-build action [WIP] Oct 16, 2023
@vladem vladem temporarily deployed to PR Unit Tests October 16, 2023 16:54 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR Unit Tests October 16, 2023 17:00 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR Unit Tests October 16, 2023 17:05 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR Unit Tests October 17, 2023 10:48 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR Unit Tests October 17, 2023 10:54 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR Unit Tests October 17, 2023 11:10 — with GitHub Actions Inactive
Dockerfile Show resolved Hide resolved
push:
# Sequence of patterns matched against refs/tags
tags:
- "v*" # Push events to matching v*, i.e. v1.0, v20.15.10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we may need re-consider this, eventually we'll have to onboard to ARS and they'll distribute the ECR repo to all the regions for EKS add on, it may be "automated" if we use the latest tag, we need to sync with them about this process -- not a blocker comment just sharing

Copy link
Contributor Author

@vladem vladem Oct 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm interesting, so I tested this, it does not work out of the box, e.g. having 2 images in repo:

  • s3-csi-driver-test:v0.0.1alpha
  • s3-csi-driver-test:v0.0.2alpha

it does not automatically resolve latest tag (I had a suspicion that it will):
Normal BackOff 8s kubelet Back-off pulling image "151381207180.dkr.ecr.eu-west-1.amazonaws.com/s3-csi-driver-test:latest"

but it seems like a feasible adjustment to tag image with the "greatest" v0.0.2 tag also as latest at the end of this action (it will require some shell scripting and version parsing though)

dlakhaws
dlakhaws previously approved these changes Oct 17, 2023
- "v*" # Push events to matching v*, i.e. v1.0, v20.15.10

env:
REGION : "us-east-1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

np: AWS_REGION instead?

@vladem vladem temporarily deployed to PR Unit Tests October 17, 2023 15:58 — with GitHub Actions Inactive
@vladem vladem merged commit 2f6da55 into main Oct 18, 2023
@vladem vladem deleted the image-action branch October 18, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants