Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add non-root end-to-end test cases to credentials test suite #327

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add non-root end-to-end test cases to credentials test suite #327

wants to merge 3 commits into from

Conversation

unexge
Copy link
Contributor

@unexge unexge commented Dec 27, 2024

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

jiaeenie
jiaeenie reviewed Jan 2, 2025
View reviewed changes
Copy link
Contributor

@jiaeenie jiaeenie left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we change this line as well? Such as replacing "uid=1000", "gid=2000" with

fmt.Sprintf("uid=%d", defaultNonRootUser),
fmt.Sprintf("gid=%d", defaultNonRootGroup))

And this line and this line to use the variable defaultNonRootGroup.

@unexge unexge force-pushed the unexge/credential-tests-non-root branch from 540618a to 1c0014d Compare January 3, 2025 14:13
@unexge
Copy link
Contributor Author

unexge commented Jan 3, 2025

Good suggestion @jiaeenie! Addressed with 1c0014d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiaeenie jiaeenie jiaeenie left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@unexge @jiaeenie