Distribute mountpoint binary instead of package #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladem
reviewed
Nov 13, 2023
| mkdir -p /mountpoint-s3 && \ | ||
| tar -xvzf mount-s3-${MOUNTPOINT_VERSION}-$MP_ARCH.tar.gz -C /mountpoint-s3 && \ | ||
| # strip debugging information to reduce binary size | ||
| strip --strip-debug /mountpoint-s3/bin/mount-s3 && \ |
There was a problem hiding this comment.
how many MBs we're saving with that? is it a good trade-off? as I understand this will make MPs traces unreadable
There was a problem hiding this comment.
also taking into the account that MP operational runbooks may rely on this info
There was a problem hiding this comment.
The binary goes from 55 MB to 12, so it's not insignificant. I will double check with the mountpoint team though.
| @@ -2,75 +2,5 @@ | |||
|
|
|||
| set -euox pipefail | |||
|
|
|||
| NSENTER_HOST="nsenter --target 1 --mount --net" | |||
There was a problem hiding this comment.
Yep glad to see this go. It was gross. And now we don't have to run with hostPID: true
Cutting down on image size and overall complexity by using the standalone tarball of mountpoint instead of installing a deb/rpm. Mountpoint links dynamically, so the container also packages a couple .so files.
dlakhaws
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cutting down on image size and overall complexity by using the standalone tarball of mountpoint instead of installing a deb/rpm. Mountpoint links dynamically, so the container also packages a couple .so files.