Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return exit code from Palace in wrapper script #153

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

sebastiangrimberg
Copy link
Contributor

Previously, even if the binary exited with non-zero exit code the wrapper script would still return 0.

@sebastiangrimberg sebastiangrimberg added bug Something isn't working minor A minor issue or improvement usage Related to usage labels Dec 13, 2023
@sebastiangrimberg sebastiangrimberg marked this pull request as ready for review December 14, 2023 06:20
Copy link
Collaborator

@hughcars hughcars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran palace -np 6 cavity_pec.json changing the exit code in main.cpp to 1, then echo $?. On main it gives 0, here it gives 1, so looks good to me.

@sebastiangrimberg sebastiangrimberg merged commit f988f35 into main Dec 14, 2023
17 checks passed
@sebastiangrimberg sebastiangrimberg deleted the sjg/palace-exitcode-fix branch December 14, 2023 14:47
@sebastiangrimberg sebastiangrimberg mentioned this pull request Dec 20, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working minor A minor issue or improvement usage Related to usage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants