Expose WavePort configuration options #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughcars
changed the base branch from
main
to
hughcars/clang-format-19-update
hughcars
force-pushed
the
hughcars/waveport-configuration-dev
branch
from
d15a435 to
b6d8c40
Compare
hughcars
changed the base branch from
hughcars/clang-format-19-update
to
main
hughcars
force-pushed
the
hughcars/waveport-configuration-dev
branch
from
b6d8c40 to
e94d07e
Compare
hughcars
force-pushed
the
hughcars/waveport-configuration-dev
branch
from
e94d07e to
c9f9934
Compare
simlapointe
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose some additional waveport configuration files in the config file. The defaults for all of these align with the existing hardcoded values, but a user can now change them if so needed. This was turned up in testing waveports on highly refined meshes where occasionally the wave port problem would not converge.