Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor measurement and printing for future features #302

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Refactor measurement and printing for future features #302

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
e56664e
Tweak build system
phdum-a Dec 3, 2024
9defb8d
Add flag for MFEM to throw not abort
phdum-a Dec 3, 2024
03e175c
Simplify printing using more fmt features
phdum-a Dec 3, 2024
b7e7f69
Add small table class for csv printing
phdum-a Dec 3, 2024
20ed17f
Add vdim to interpolation operator
phdum-a Dec 3, 2024
26353fb
First pass at new postpro printers
phdum-a Dec 3, 2024
80d2531
Clean up while loops
phdum-a Dec 3, 2024
3a779c1
Centralizes making output directory
phdum-a Dec 3, 2024
0f72bd0
Change post_dir to fs::path
phdum-a Dec 3, 2024
64c2c9a
Rework PostOperator
phdum-a Dec 3, 2024
8f68b32
Add missing include
phdum-a Dec 3, 2024
f58ccbf
Fix table tests with changed default
phdum-a Dec 3, 2024
ea3c62d
Clang-tidy tweaks
phdum-a Dec 4, 2024
5a106c8
Bugfix in eigenmode port_Q printer
phdum-a Dec 12, 2024
20660d6
Fix bug in s-parameters printer
phdum-a Dec 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions cmake/ExternalMFEM.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,9 @@ if(CMAKE_BUILD_TYPE MATCHES "Debug|debug|DEBUG")
endif()
endif()

# Replace mfem abort calls with exceptions for testing, default off
set(PALACE_MFEM_USE_EXCEPTIONS CACHE NO "MFEM throw exceptsions instead of abort calls")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set(PALACE_MFEM_USE_EXCEPTIONS CACHE NO BOOL "MFEM throw exceptsions instead of abort calls")
The BOOL is needed to calm a warning about using the cache. However if you do that, the mfem build then fails due to their parsing of the variable, giving

set(MFEM_DEBUG OFF)
set(MFEM_USE_EXCEPTIONS CACHE)
set(MFEM_USE_ZLIB YES)

in the mfem cmake cache. I think sticking with
set(PALACE_MFEM_USE_EXCEPTIONS NO) rather than needing to work around mfem's cmake approach.


set(MFEM_OPTIONS ${PALACE_SUPERBUILD_DEFAULT_ARGS})
list(APPEND MFEM_OPTIONS
"-DCMAKE_CXX_COMPILER=${CMAKE_CXX_COMPILER}"
Expand All @@ -91,6 +94,7 @@ list(APPEND MFEM_OPTIONS
"-DMFEM_USE_METIS_5=YES"
"-DMFEM_USE_CEED=NO"
"-DMFEM_USE_SUNDIALS=${PALACE_WITH_SUNDIALS}"
"-DMFEM_USE_EXCEPTIONS=${PALACE_MFEM_USE_EXCEPTIONS}"
)
if(PALACE_WITH_STRUMPACK OR PALACE_WITH_MUMPS)
list(APPEND MFEM_OPTIONS
Expand Down