Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multi-excitation support to driven solver #309

Draft
wants to merge 17 commits into
base: phdum/new_postpro
Choose a base branch
from
Draft

Add multi-excitation support to driven solver #309

wants to merge 17 commits into from

Conversation

phdum-a
Copy link
Collaborator

@phdum-a phdum-a commented Dec 4, 2024 •
edited
Loading

  • Enable looping over different excitations in the driven solver
  • Extend config file to allow integer specification of "excitation" in LumpedPort, WavePort or SurfaceCurrent
  • Add PortExcitationHelper to manage complex excitation patterns
  • Tweak github tests: compile MFEM to throw exceptions not abort; make timeout shorter

ToDos:

  • Fix paraview conventions
  • Update docs with new config changes
  • Update changelog
  • Add regression tests with multiple exciataions

@phdum-a
Copy link
Collaborator Author

phdum-a commented Dec 4, 2024

Code lives on top of #302 — that should be merged into main first and this branch rebased.

@phdum-a phdum-a force-pushed the phdum/multi_excitation branch 2 times, most recently from 085d483 to 16067a5 Compare December 5, 2024 18:29
@phdum-a phdum-a changed the base branch from main to phdum/new_postpro December 5, 2024 18:37
@phdum-a phdum-a force-pushed the phdum/multi_excitation branch 3 times, most recently from bbfaf57 to 6692a00 Compare December 6, 2024 03:12
phdum-a added 17 commits December 11, 2024 17:28
@phdum-a
Extend excitation in port config from bool to int
b43d264 
- Check that excitations are specified either as int or as bool but not both
- Add tests
- But PreprocessFile into header for use in testing
@phdum-a
Make config index positive and port indices unique
47a3c56 
- Add tests
- Cleanup names
- Add excitation minimum to json schema
@phdum-a
Add excitation helper; default excitation index
dd854ab 
- Helper for data from individual ports
- Promote excitation index in default situation
- Add json serialization
@phdum-a
Thread through int excitation index in operators
6783413 
- Clean up port excitation printing in driven and transient solvers
@phdum-a
[github] Add shorter timeouts than default
c5d8951
@phdum-a
[github] Compile with exceptions in unit-tests workflow
8a12143
@phdum-a
Ensure single excitation time transient solver
e3e7334
@phdum-a
Save excitations in metadata
9bc8a60
@phdum-a
Add multi-excitation support to driven solver
476ef0d 
- Add multi-column PostPrinters
- Generalize paraview paths
- Allow for switching paraview files in PostOp
- Split MRI out of RomOperator; have one for each excitation
- Allow chaning the excitation index in RomOperator
@phdum-a
Remove PROM printing; simplify
68151e3
@phdum-a
Strong type excitation index
f8be2a6 
- Avoid implicit conversion bugs
@phdum-a
Restore single port excitation req for S_ij
7c3dad8 
- Add helper methods to check special excitation patterns
- Simplify S_ij printer
@phdum-a
Remove unneeded default ctors for printers
43de2bd
@phdum-a
Fix formatting
6d344e3
@phdum-a
Fix formatter const qualified
aa20f1c
@phdum-a
Add fmt header for spack build issue
7fd4b90
@phdum-a
Fix max_size meaning in PROM construction
ac8cd41
@phdum-a phdum-a force-pushed the phdum/multi_excitation branch from 6692a00 to ac8cd41 Compare December 12, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@phdum-a