Complex-valued coarse preconditioner #310
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simlapointe
added
enhancement
…sing extra arg, and use the new SetSubVector
hughcars
requested changes
Dec 18, 2024
There was a problem hiding this comment.
Tried it out with MGMaxLevels 1 on the cavity, great that the ksp solves in a single iteration now (with an exact preconditioner effectively).
I pushed a branch with some suggested changes hughcars/complex-pc:
- A new
SetSubVectorto avoid the use of idx. - Reordering some callsites to put IoData ahead of all across the code base. This then means the variadic function avoids using an extra argument for data that was already being pass in as part of
IoData.
hughcars
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change uses the true complex-valued system matrix for the coarse solve (sparse direct solve) instead of the real-valued approximation. We still use the real-valued sparse matrix libraries and pass the 2x2 block matrix
[A_r -A_i; A_i A_r]to the solver. Further speedup could be obtained by using complex-valued sparse matrix libraries, but this would require a bit more work, including updating MFEM interfaces.