Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spack build issue when using ^ in depends_on #315

Merged
merged 1 commit into from
Dec 13, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions spack/local/packages/palace/package.py
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,8 @@ class Palace(CMakePackage, CudaPackage, ROCmPackage):
depends_on(f"superlu-dist{cuda_variant}", when=f"+superlu-dist{cuda_variant}")
depends_on(f"strumpack{cuda_variant}", when=f"+strumpack{cuda_variant}")
depends_on(f"sundials{cuda_variant}", when=f"+sundials{cuda_variant}")
depends_on(f"slepc{cuda_variant} ^petsc{cuda_variant}", when=f"+slepc{cuda_variant}")
depends_on(f"slepc{cuda_variant}", when=f"+slepc{cuda_variant}")
depends_on(f"petsc{cuda_variant}", when=f"+slepc{cuda_variant}")
depends_on(f"magma{cuda_variant}", when=f"+magma{cuda_variant}")
with when("+rocm"):
for arch in ROCmPackage.amdgpu_targets:
Expand All @@ -134,7 +135,8 @@ class Palace(CMakePackage, CudaPackage, ROCmPackage):
depends_on(f"superlu-dist{rocm_variant}", when=f"+superlu-dist{rocm_variant}")
depends_on(f"strumpack{rocm_variant}", when=f"+strumpack{rocm_variant}")
depends_on(f"sundials{rocm_variant}", when=f"+sundials{rocm_variant}")
depends_on(f"slepc{rocm_variant} ^petsc{rocm_variant}", when=f"+slepc{rocm_variant}")
depends_on(f"slepc{rocm_variant}", when=f"+slepc{rocm_variant}")
depends_on(f"petsc{rocm_variant}", when=f"+slepc{rocm_variant}")
depends_on(f"magma{rocm_variant}", when=f"+magma{rocm_variant}")

# Palace always builds its own internal MFEM, libCEED, and GSLIB
Expand Down
Loading