Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retire DeepSpeed mode due to security issue with supported version #1116

Merged
merged 3 commits into from
Oct 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/workflows/push_pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@ jobs:
run: python -m pip install --upgrade pip
- name: Sockeye requirements
run: pip install -r requirements/requirements.txt
- name: DeepSpeed requirements
run: pip install -r requirements/requirements.deepspeed.txt
- name: Faiss requirements
run: |
if [ "$RUNNER_OS" == "Linux" ]; then
Expand All @@ -57,4 +55,4 @@ jobs:
run: check-manifest --ignore sockeye/git_version.py
- name: System tests
run: |
pytest test/system
pytest test/system
2 changes: 0 additions & 2 deletions .github/workflows/python-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@ jobs:
pip install setuptools wheel twine
- name: Sockeye requirements
run: pip install -r requirements/requirements.txt
- name: DeepSpeed requirements
run: pip install -r requirements/requirements.deepspeed.txt
- name: Development requirements
run: pip install -r requirements/requirements.dev.txt
- name: Unit tests
Expand Down
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,12 @@ Note that Sockeye has checks in place to not translate with an old model that wa

Each version section may have subsections for: _Added_, _Changed_, _Removed_, _Deprecated_, and _Fixed_.

## [3.1.39]

### Removed

- Retired DeepSpeed support due to security issue (remote code execution vulnerability) with the supported version of DeepSpeed (0.6.5).

## [3.1.38]

### Fixed
Expand Down
1 change: 0 additions & 1 deletion requirements/requirements.deepspeed.txt

This file was deleted.

2 changes: 1 addition & 1 deletion sockeye/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@
# express or implied. See the License for the specific language governing
# permissions and limitations under the License.

__version__ = '3.1.38'
__version__ = '3.1.39'
2 changes: 1 addition & 1 deletion test/unit/test_deepspeed.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
try:
import deepspeed
deepspeed_installed = True
except:
except ImportError:
deepspeed_installed = False


Expand Down
Loading