chore: Update MitigationCandidate

awslabs · Sep 10, 2024 · e871287 · e871287
1 parent c292020
commit e871287
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/packages/threat-composer/src/components/threats/Header/index.tsx b/packages/threat-composer/src/components/threats/Header/index.tsx
@@ -40,7 +40,7 @@ const Header: FC<HeaderProps> = ({
     return (
       <SpaceBetween direction="horizontal" size="xs">
         <Button onClick={onCancel}>Threat list</Button>
-        <Button onClick={onStartOver}>Start over</Button>
+        {onStartOver && <Button onClick={onStartOver}>Start over</Button>}
         <Button variant="primary" onClick={onComplete} disabled={!statement.statement}>
           {saveButtonText}
         </Button>

diff --git a/packages/threat-composer/src/components/threats/MitigationCandidates/index.tsx b/packages/threat-composer/src/components/threats/MitigationCandidates/index.tsx
@@ -59,11 +59,13 @@ const MitigationCandidates: FC<MitigationCandidatesProp> = ({
       if (threatPackId && threatPackThreatId) {
         const mitigationCandidates = await getMitigationCandidates(threatPackId, threatPackThreatId);
         setMitigations(mitigationCandidates);
+      } else {
+        setMitigations([]);
       }
     };
 
     setupMitigations().catch(err => console.log('Error', err));
-  }, [threatPackId, threatPackThreatId]);
+  }, [threatPackId, threatPackThreatId, getMitigationCandidates]);
 
   const colDef: ColumnDefinition<Mitigation>[] = useMemo(() => [
     {

diff --git a/packages/threat-composer/src/components/threats/ThreatStatementEditor/index.tsx b/packages/threat-composer/src/components/threats/ThreatStatementEditor/index.tsx
@@ -97,7 +97,7 @@ const ContentLayout: FC<PropsWithChildren<{
   editingStatement: TemplateThreatStatement;
   saveButtonText: string;
   onCancel: () => void;
-  onStartOver: () => void;
+  onStartOver?: () => void;
   onComplete: () => void;
 }>> = ({
   children,
@@ -389,7 +389,7 @@ export const ThreatStatementEditorInner: FC<ThreatStatementEditorProps & { editi
       saveButtonText={saveButtonText}
       editingStatement={editingStatement}
       onCancel={handleCancel}
-      onStartOver={handleStartOver}
+      onStartOver={isExampleVisible ? handleStartOver : undefined}
       onComplete={handleComplete}
     >
       <SpaceBetween direction='vertical' size='l'>