-
-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add python-gino support #71
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/flortz/fastapi-crudrouter/ZijzguwGFtJzKP6migXed5ubt3oR |
Awesome looks good for the most part. The only thing remaining is for it to be added to the unit tests. This is done in the |
Thank you for your feedback. Yes, I will add unit tests |
Awesome! It may be tricky as currently all the other implementations are using SQLlite. However I should be able to add Postgres to the CI/CD pipeline. |
Good,thank you.! |
@awtkns Hi, |
Hey @Turall thanks for getting the tests working, I am going to be getting them working in the CI/CD pipeline over the weekend and then it should be good to merge! |
Thanks for the reply. When are you planning to release a new version? We are waiting for gino support :) |
Soon! Within the next 2-3 days (We also need a docs page for it). The next version will include Gino. Then the version after (which is basically done (I just have implement it for gino) will include query param filtering and sorting #61 |
Thank you, waiting for new release |
# Conflicts: # .github/workflows/pytest.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @Turall, thanks for all your help. Change will be released with this merge (v0.8.0)
closes #70