Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add python-gino support #71

Merged
merged 34 commits into from
Jul 6, 2021
Merged

add python-gino support #71

merged 34 commits into from
Jul 6, 2021

Conversation

Turall
Copy link
Contributor

@Turall Turall commented Jun 1, 2021

closes #70

@vercel
Copy link

vercel bot commented Jun 1, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/flortz/fastapi-crudrouter/ZijzguwGFtJzKP6migXed5ubt3oR
✅ Preview: https://fastapi-crudrouter-git-fork-turall-master-flortz.vercel.app

@awtkns
Copy link
Owner

awtkns commented Jun 1, 2021

Awesome looks good for the most part. The only thing remaining is for it to be added to the unit tests. This is done in the tests/implementations folder. I can also add it sometime in the next week if you would rather.

@awtkns awtkns self-requested a review June 1, 2021 19:11
@Turall
Copy link
Contributor Author

Turall commented Jun 2, 2021

Awesome looks good for the most part. The only thing remaining is for it to be added to the unit tests. This is done in the tests/implementations folder. I can also add it sometime in the next week if you would rather.

Thank you for your feedback. Yes, I will add unit tests

@awtkns
Copy link
Owner

awtkns commented Jun 2, 2021

Awesome! It may be tricky as currently all the other implementations are using SQLlite. However I should be able to add Postgres to the CI/CD pipeline.

@Turall
Copy link
Contributor Author

Turall commented Jun 2, 2021

Awesome! It may be tricky as currently all the other implementations are using SQLlite. However I should be able to add Postgres to the CI/CD pipeline.

Good,thank you.!

@Turall
Copy link
Contributor Author

Turall commented Jun 25, 2021

@awtkns Hi,
I've added test cases for the gino backend. Sorry for being late, I have been very busy.

@awtkns
Copy link
Owner

awtkns commented Jun 26, 2021

Hey @Turall thanks for getting the tests working, I am going to be getting them working in the CI/CD pipeline over the weekend and then it should be good to merge!

@Turall
Copy link
Contributor Author

Turall commented Jun 27, 2021

Hey @Turall thanks for getting the tests working, I am going to be getting them working in the CI/CD pipeline over the weekend and then it should be good to merge!

Thanks for the reply. When are you planning to release a new version? We are waiting for gino support :)

@awtkns
Copy link
Owner

awtkns commented Jun 27, 2021

Soon! Within the next 2-3 days (We also need a docs page for it). The next version will include Gino. Then the version after (which is basically done (I just have implement it for gino) will include query param filtering and sorting #61

@Turall
Copy link
Contributor Author

Turall commented Jun 28, 2021

Soon! Within the next 2-3 days (We also need a docs page for it). The next version will include Gino. Then the version after (which is basically done (I just have implement it for gino) will include query param filtering and sorting #61

Thank you, waiting for new release

Copy link
Owner

@awtkns awtkns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @Turall, thanks for all your help. Change will be released with this merge (v0.8.0)

@awtkns awtkns merged commit 1711d00 into awtkns:master Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support python-gino
3 participants