-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added IPv6 option at client side #1456
base: master
Are you sure you want to change the base?
Conversation
Documentation lacked the information of how fio handles IPv6 in client/server environment. server side option is present but it is quite unclear about how to implement in client end.
Please update HOWTO.rst as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From: bose-abhishek <[email protected]> Date: Thu, 25 Aug 2022 22:29:57 +0530 Subject: [PATCH] Added IPv6 option at client side Documentation lacked the information of how fio handles IPv6 in client/server environment. server side option is present but it is quite unclear about how to implement in client end. --- fio.1 | 6 ++++++ 1 file changed, 6 insertions(+)
-
The commit message should contain a Signed-off-by tag with your
real name and real email. (Note that you put it in the pull request
body now, it should've been in the commit message). -
Please word-wrap the explanation in the commit message at 72-chars.
-
Don't use a GitHub anonymous name and email as the author ("From"
header in the patch). Use a real name and a real email.
@bose-abhishek can you please address the two review comments? |
Documentation lacked the information of how fio handles IPv6 in client/ server environment. Server side option is present but it is quite unclear about how to implement in client end. Signed-off-by: Abhishek Bose [email protected]
Documentation lacked the information of how fio handles IPv6 in client/ server environment. Server side option is present but it is quite unclear about how to implement in client end. Signed-off-by: Abhishek Bose [email protected]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge branch 'axboe:master' into patch-1
-
Please do not make a merge commit when you sync your branch with
upstream. This is not necessary. Please rebase your commits on
top of the upstream HEAD commit (axboe/fio master), then do a force
push. -
Please drop your old commit. This branch still contains a commit
that was done wrong. -
The Signed-off-by format is wrong, the correct one looks like this:
Signed-off-by: Ammar Faizi <[email protected]>
Signed-off-by:
.- Name.
- Email wrapped with angle brackets.
- Please put a blank line before the
Signed-off-by
line.
Added IPv6 option at client side
Documentation lacked the information of how fio handles IPv6 in client/server environment.
server side option is present but it is quite unclear about how to implement in client end.
Signed-off-by: Abhishek Bose [email protected]