Remove librpma engine as librpma library is no longer maintained #1811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4e2bd71.
This reverts commit d3061c1.
…wc()" This reverts commit d479658.
…se()" This reverts commit e662bc9.
This reverts commit e4c4625.
Remove librpma support as rpma project is already archived: https://github.com/pmem/rpma Signed-off-by: Tomasz Gromadzki <[email protected]>
Signed-off-by: Tomasz Gromadzki <[email protected]>
janekmi
suggested changes
Aug 29, 2024
ci/actions-install.sh
Outdated
| @@ -54,8 +54,7 @@ DPKGCFG | |||
| libiscsi-dev | |||
| libnbd-dev | |||
| libpmem-dev | |||
| libpmem2-dev | |||
| libprotobuf-c-dev | |||
| libpmemblk-dev | |||
There was a problem hiding this comment.
Restoring libpmemblk-dev here seems unnecessary.
fio.1
Outdated
| @@ -2431,7 +2431,7 @@ The TCP or UDP port to bind to or connect to. If this is used with | |||
| this will be the starting port number since fio will use a range of | |||
| ports. | |||
| .TP | |||
| .BI (rdma,librpma_*)port \fR=\fPint | |||
| .BI (rdma)port | |||
There was a problem hiding this comment.
It seems this bit: \fR=\fPint still makes sense. Please consider keeping it.
Signed-off-by: Tomasz Gromadzki <[email protected]>
janekmi
approved these changes
Aug 29, 2024
grom72
changed the title
|
I have looked through this and see no issues, but we are having a long weekend in the US, so I will wait until Tuesday to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove librpma engines as the librpma library project has been archived on GitHub.
Please confirm that your commit message(s) follow these guidelines:
aren't something like a URL at 72-74 chars.
Reminders:
cconv.c and bump FIO_SERVER_VER in server.h
FIO_IOOPS_VERSION in ioengines.h.