Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates select interp #93

Merged
merged 3 commits into from
Sep 13, 2023
Merged

Conversation

kthyng
Copy link
Member

@kthyng kthyng commented Sep 13, 2023

Pull Request Reminders

  • Add tests for the new functionality.
  • Add a bullet to docs/whats_new.rst describing your new work. If not already present, add a new section at the top of the document stating "[expected new version number] (unreleased)", for example: "v0.7.3 (unreleased)"

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch coverage: 51.55% and project coverage change: -7.18% ⚠️

Comparison is base (9a7e4ae) 92.67% compared to head (aa5a819) 85.49%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
- Coverage   92.67%   85.49%   -7.18%     
==========================================
  Files          19       20       +1     
  Lines        1529     1724     +195     
==========================================
+ Hits         1417     1474      +57     
- Misses        112      250     +138     
Flag Coverage Δ
unittests 85.49% <51.55%> (-7.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
extract_model/utils.py 81.70% <14.81%> (-0.66%) ⬇️
extract_model/extract_model.py 54.81% <36.20%> (-22.70%) ⬇️
extract_model/preprocessing.py 64.42% <64.42%> (ø)
extract_model/__init__.py 80.00% <100.00%> (+2.22%) ⬆️
extract_model/accessor.py 93.33% <100.00%> (ø)
tests/grids/test_triangular_mesh.py 100.00% <100.00%> (ø)
tests/test_accessor.py 92.59% <100.00%> (+0.28%) ⬆️
tests/test_em.py 98.80% <100.00%> (ø)
tests/test_sel2d.py 98.46% <100.00%> (-1.54%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kthyng kthyng merged commit cd004a4 into axiom-data-science:main Sep 13, 2023
11 of 13 checks passed
@kthyng kthyng deleted the updates_select_interp branch September 13, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant