Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controlled selections for em.select #96

Merged
merged 8 commits into from
Oct 12, 2023

Conversation

kthyng
Copy link
Member

@kthyng kthyng commented Oct 12, 2023

Pull Request Reminders

  • Add tests for the new functionality.
  • Add a bullet to docs/whats_new.rst describing your new work. If not already present, add a new section at the top of the document stating "[expected new version number] (unreleased)", for example: "v0.7.3 (unreleased)"

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (3193646) 82.36% compared to head (7c05abf) 88.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
+ Coverage   82.36%   88.00%   +5.63%     
==========================================
  Files          20       22       +2     
  Lines        1764     2092     +328     
==========================================
+ Hits         1453     1841     +388     
+ Misses        311      251      -60     
Flag Coverage Δ
unittests 88.00% <98.19%> (+5.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
tests/make_test_datasets.py 100.00% <100.00%> (ø)
tests/test_utils.py 99.25% <ø> (ø)
extract_model/extract_model.py 70.84% <90.90%> (+16.02%) ⬆️
tests/test_datasets.py 98.22% <98.22%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kthyng kthyng merged commit 7070404 into axiom-data-science:main Oct 12, 2023
12 checks passed
@kthyng kthyng deleted the featuretypes branch October 12, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant