feat: middleware #228
feat: middleware #228
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
random request: could the |
There was a problem hiding this comment.
Overall looks good, but I have couple of points.
- Its missing documentation on how to use it.
- Perhaps now we can get deprecated usage of
NEXT_PUBLIC_AXIOM_TOKENand update the docs to mentionAXIOM_TOKENinstead. - There is now a custom endpoint added by @c-ehrlich, not sure if we need to handle anything related to that or the config takes care of it.
src/middleware.ts
Outdated
| const webVitalsEndpoint = axiomConfig.getIngestURL(EndpointType.webVitals); | ||
| const logsEndpoint = axiomConfig.getIngestURL(EndpointType.logs); | ||
|
|
||
| const headers = { |
There was a problem hiding this comment.
Our fetch sends a special UserAgent header to identify which SKS is sending the request. Its missing in here. Perhaps you can just proxy the request headers and adds the token on top of?
There was a problem hiding this comment.
Addressed this in the last commit
src/middleware.ts
Outdated
| ); | ||
|
|
||
| // Return a 204 to the client | ||
| return new NextResponse(null, { status: 204 }); |
There was a problem hiding this comment.
Shouldn't status be returned as error if the request fails? Users might not notice if it always returns 204 even if it fails.
There was a problem hiding this comment.
The last commit checks if .waitUntil is defined and, if not, awaits the response. We can decide not to use .waitUntil altogether for this case since we are pretty much using the middleware like an API route here and not redirecting or continuing execution after it finishes the fetch
gabrielelpidio
force-pushed
the
luna/middleware
branch
from
26dd9bd to
6b6ef2f
Compare
gabrielelpidio
force-pushed
the
luna/middleware
branch
from
d859e20 to
1484a02
Compare
this adds middleware that will allow users to proxy their logs and webvital reports to their backend avoiding the need to provide their Axiom token and dataset to the frontend.