feat: disable single-library mode for dist=false #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good thought, I'll check and see how testable this seems. |
mistydemeo
force-pushed
the
dist-changes
branch
from
f9fd037 to
8f22cb1
Compare
|
Simple enough, was able to add it to a new test to ensure it errors out when |
ashleygwilliams
approved these changes
Oct 8, 2024
|
Test needs a little more work. This doesn't test the precise conditions that this PR addresses; that test passes on |
|
Found a proper repro case; I'm readying a test case that would work here. |
mistydemeo
force-pushed
the
dist-changes
branch
from
8f22cb1 to
f924934
Compare
|
Have a proper repro case now; I can confirm this test fails on main and passes in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past, we'd ignore
dist=falsewhen trying to enable single-package/library mode. This is, frankly, quite confusing and not desirable. Even if it's a slightly backwards incompatible change, we should make this do what it actually says.Fixes #1287.