Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor dist init and split out dist migrate #1611

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

duckinator
Copy link
Contributor

@duckinator duckinator commented Dec 6, 2024

  • dist init still works as on main
  • dist migrate does the migration part of dist init
  • dist init's migration functionality is now implemented in terms of dist migrate

This shows dist migrate on its own:

image

And this shows that dist migrate is only a migration, and explicitly does not do the re-init part:

image

@duckinator

This comment was marked as resolved.

@duckinator duckinator marked this pull request as ready for review December 9, 2024 21:04
Copy link
Contributor

@mistydemeo mistydemeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Tested that dist init on a new, uninitted workspace works fine, and that dist migrate also works on an initted workspace with Cargo.toml. Likewise, dist init with or without the migration is doing the right thing.

cargo-dist/src/init.rs Outdated Show resolved Hide resolved
@duckinator duckinator merged commit 5589242 into main Dec 10, 2024
18 checks passed
@duckinator duckinator deleted the init-refactor branch December 10, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants