fix: don't respect cargo-dist's install hints for curl-sh exprs

The dist-manifest.json fundamentally lacks the information to generate perfect pretty curl-sh exprs, because it needs to be uploaded before the create-release endpoint tells us this url format. As such, oranda should ignore the manifest for these install-hints, and instead use the inference backend for them, which can use the URLs returned by the list-releases endpoint (or the github release's base url).
axodotdev · Dec 19, 2023 · 60ab1fd · 60ab1fd
1 parent aba8a57
commit 60ab1fd
Show file tree

Hide file tree

Showing 4 changed files with 115 additions and 112 deletions.
diff --git a/src/data/cargo_dist.rs b/src/data/cargo_dist.rs
@@ -61,11 +61,14 @@ impl ReleaseArtifacts {
                             {
                                 preference = InstallerPreference::Custom;
                                 None
+                            } else if id.ends_with(".sh") || id.ends_with(".ps1") {
+                                // We have more info to do a better job than cargo-dist on
+                                // `curl | sh` exprs, inference will handle this for us!
+                                continue;
                             } else {
                                 preference = InstallerPreference::Script;
                                 file
                             };
-
                             method = InstallMethod::Run {
                                 file,
                                 run_hint: install_hint.clone(),