fix(artifacts): fix copypasta fail for run hint inference #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebased to pull in #451 for green checks |
|
Weirdly, I'd expect https://opensource.axo.dev/oranda/ to be broken by this bug, but it seems to show the correct instructions:
|
|
@msfjarvis does this happen on any of your pages? just trying to get an overview of when exactly this breaks |
It does. The repository is here, and the deployed page can be found here. |
|
okay, weird, but it doesn't change our own site output when applying locally, so it's fine |
shadows-withal
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The checks for PowerShell and
shwere swapped around which resulted in generated sites recommendingirmfor shell scripts andcurlfor PowerShell ones :DNo tests failed post this change so I guess there is no coverage, I can add a test if someone can point to where it should go.