Hymba multipack support #2118
Closed
Hymba multipack support #2118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
a small e2e test for this with and without packing and validating the train_loss would be good to have. |
winglian
force-pushed
the
hymba_multipack
branch
from
ddbbd6e to
ca47276
Compare
winglian
requested changes
Dec 7, 2024
There was a problem hiding this comment.
Needs e2e test as well as a chat template setup. see https://huggingface.co/nvidia/Hymba-1.5B-Instruct/blob/main/tokenizer_config.json#L40
|
rebased in #2178 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support for Hymba multipacking
Motivation and Context
How has this been tested?
Screenshots (if appropriate)
Types of changes
Social Handles (Optional)