[feature] add pytorch profiling #2182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
winglian
commented
Dec 13, 2024
winglian
commented
djsaunde
approved these changes
Dec 13, 2024
NanoCode012
reviewed
Dec 13, 2024
| ): | ||
| if state.global_step == self.steps_to_profile: | ||
| snapshot = torch.cuda.memory._snapshot() # pylint: disable=protected-access | ||
| with open(Path(args.output_dir) / "snapshot.pickle", "wb") as fout: |
There was a problem hiding this comment.
Can we maybe output to a non-pickle file for safety reasons (shared to others , tampered, etc)? How would a person also read this file and display it?
There was a problem hiding this comment.
I don't believe there are any other options that the visualizer supports as input. I added docs but forgot to push them earlier.
djsaunde
pushed a commit
that referenced
this pull request
Dec 16, 2024
* add pytorch profiling * kick off the profiler asap since things may get allcoated before train start * document feature * add url for visualizer [skip ci]
djsaunde
pushed a commit
that referenced
this pull request
Dec 17, 2024
* add pytorch profiling * kick off the profiler asap since things may get allcoated before train start * document feature * add url for visualizer [skip ci]
djsaunde
pushed a commit
that referenced
this pull request
Dec 17, 2024
* add pytorch profiling * kick off the profiler asap since things may get allcoated before train start * document feature * add url for visualizer [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.