Skip to content

Commit

Permalink
Fix warnings
Browse files Browse the repository at this point in the history
- Deprecated code
- Bad persistent attributes
- Set encoding to UTF-8
  • Loading branch information
ivy-lli committed Nov 11, 2024
1 parent 705bf31 commit 5aea164
Show file tree
Hide file tree
Showing 33 changed files with 55 additions and 76 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
eclipse.preferences.version=1
encoding/<project>=UTF-8
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
"modifiers" : [ "PERSISTENT" ]
}, {
"name" : "person",
"type" : "com.axonivy.connectivity.soap.service.client.Person",
"modifiers" : [ "PERSISTENT" ]
"type" : "com.axonivy.connectivity.soap.service.client.Person"
} ]
}
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
"isBusinessCaseData" : false,
"fields" : [ {
"name" : "persons",
"type" : "List<com.axonivy.connectivity.soap.service.client.Person>",
"modifiers" : [ "PERSISTENT" ]
"type" : "List<com.axonivy.connectivity.soap.service.client.Person>"
} ]
}
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,9 @@
"isBusinessCaseData" : false,
"fields" : [ {
"name" : "persons",
"type" : "List<com.axonivy.connectivity.Person>",
"modifiers" : [ "PERSISTENT" ]
"type" : "List<com.axonivy.connectivity.Person>"
}, {
"name" : "person",
"type" : "com.axonivy.connectivity.Person",
"modifiers" : [ "PERSISTENT" ]
"type" : "com.axonivy.connectivity.Person"
} ]
}
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
style="display:block; height:200px; padding:5px; background-color: #CEE5CE; overflow-y: auto;" />
</div>

<p:commandButton onclick="send(); return false;" value="Send" update="form" icon="fa-solid fa-send"
<p:commandButton onclick="send(); return false;" value="Send" update="form" icon="fa-solid fa-paper-plane"
style="float:right;" />
write:
<h:inputText id="sendMsg"></h:inputText>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@
"modifiers" : [ "PERSISTENT" ]
}, {
"name" : "fileDownload",
"type" : "org.primefaces.model.StreamedContent",
"modifiers" : [ "PERSISTENT" ]
"type" : "org.primefaces.model.StreamedContent"
}, {
"name" : "listFile",
"type" : "java.util.List<String>",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@
"isBusinessCaseData" : false,
"fields" : [ {
"name" : "editPerson",
"type" : "com.axonivy.connectivity.Person",
"modifiers" : [ "PERSISTENT" ]
"type" : "com.axonivy.connectivity.Person"
}, {
"name" : "firstName",
"type" : "String",
Expand All @@ -17,11 +16,9 @@
"modifiers" : [ "PERSISTENT" ]
}, {
"name" : "response",
"type" : "javax.ws.rs.core.Response",
"modifiers" : [ "PERSISTENT" ]
"type" : "javax.ws.rs.core.Response"
}, {
"name" : "persons",
"type" : "List<com.axonivy.connectivity.Person>",
"modifiers" : [ "PERSISTENT" ]
"type" : "List<com.axonivy.connectivity.Person>"
} ]
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
eclipse.preferences.version=1
encoding/<project>=UTF-8
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
eclipse.preferences.version=1
encoding/<project>=UTF-8
4 changes: 2 additions & 2 deletions html-dialog/html-dialog-demos/processes/Input.p.json
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,8 @@
"String locale = httpRequest.getFirstParameter(\"language\");",
"if (locale != \"\")",
"{",
" ivy.session.setContentLocale(new Locale(locale));",
" ivy.session.setFormattingLocale(new Locale(locale));",
" ivy.session.setContentLocale(Locale.of(locale));",
" ivy.session.setFormattingLocale(Locale.of(locale));",
"}"
]
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
"isBusinessCaseData" : false,
"fields" : [ {
"name" : "person",
"type" : "ch.ivyteam.htmldialog.demo.input.beanValidation.Person",
"modifiers" : [ "PERSISTENT" ]
"type" : "ch.ivyteam.htmldialog.demo.input.beanValidation.Person"
} ]
}
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@
"isBusinessCaseData" : false,
"fields" : [ {
"name" : "fileUploadEvent",
"type" : "org.primefaces.event.FileUploadEvent",
"modifiers" : [ "PERSISTENT" ]
"type" : "org.primefaces.event.FileUploadEvent"
}, {
"name" : "images",
"type" : "List<String>",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@
"type" : "String"
}, {
"name" : "fileDownload",
"type" : "org.primefaces.model.StreamedContent",
"modifiers" : [ "PERSISTENT" ]
"type" : "org.primefaces.model.StreamedContent"
}, {
"name" : "showContent",
"type" : "Boolean",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,19 +9,16 @@
"modifiers" : [ "PERSISTENT" ]
}, {
"name" : "searchResult",
"type" : "List<ch.ivyteam.ivy.security.IUser>",
"modifiers" : [ "PERSISTENT" ]
"type" : "List<ch.ivyteam.ivy.security.IUser>"
}, {
"name" : "selectedUserId",
"type" : "String",
"modifiers" : [ "PERSISTENT" ]
}, {
"name" : "userViaAjax",
"type" : "ch.ivyteam.ivy.security.IUser",
"modifiers" : [ "PERSISTENT" ]
"type" : "ch.ivyteam.ivy.security.IUser"
}, {
"name" : "selectedUserViaFacesConverter",
"type" : "ch.ivyteam.ivy.security.IUser",
"modifiers" : [ "PERSISTENT" ]
"type" : "ch.ivyteam.ivy.security.IUser"
} ]
}
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
"fields" : [ {
"name" : "lazyModel",
"type" : "org.primefaces.model.LazyDataModel",
"comment" : "Model is lazy loaded",
"modifiers" : [ "PERSISTENT" ]
"comment" : "Model is lazy loaded"
} ]
}
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
"isBusinessCaseData" : false,
"fields" : [ {
"name" : "persons",
"type" : "org.primefaces.model.DualListModel",
"modifiers" : [ "PERSISTENT" ]
"type" : "org.primefaces.model.DualListModel"
} ]
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
eclipse.preferences.version=1
encoding/<project>=UTF-8
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
eclipse.preferences.version=1
encoding/<project>=UTF-8
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@
"modifiers" : [ "PERSISTENT" ]
}, {
"name" : "memberType",
"type" : "rule.engine.demo.enums.MemberType",
"modifiers" : [ "PERSISTENT" ]
"type" : "rule.engine.demo.enums.MemberType"
}, {
"name" : "discount",
"type" : "Number",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
"modifiers" : [ "PERSISTENT" ]
}, {
"name" : "memberType",
"type" : "rule.engine.demo.enums.MemberType",
"modifiers" : [ "PERSISTENT" ]
"type" : "rule.engine.demo.enums.MemberType"
} ]
}
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@

<div class="command-btns" style="margin-top: 10px">
<p:commandButton id="applyDRL" actionListener="#{logic.applyRulesFromDRL}" value="Apply DRL Rules"
update="form" icon="fa-solid fa-file-text-o" />
update="form" icon="fa-solid fa-file" />
<p:commandButton id="applyDecisionTable" style="margin-left:10px"
actionListener="#{logic.applyRulesFromDecisionTable}" value="Apply Decision Table Rules" update="form"
icon="fa-solid fa-table" />
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
eclipse.preferences.version=1
encoding/<project>=UTF-8
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,7 @@
"modifiers" : [ "PERSISTENT" ]
}, {
"name" : "taskNotes",
"type" : "List<ch.ivyteam.ivy.workflow.INote>",
"modifiers" : [ "PERSISTENT" ]
"type" : "List<ch.ivyteam.ivy.workflow.INote>"
}, {
"name" : "adhoc",
"type" : "Boolean",
Expand Down
10 changes: 5 additions & 5 deletions workflow/workflow-demos/processes/AgileBPM/AgileBPM.p.json
Original file line number Diff line number Diff line change
Expand Up @@ -455,15 +455,15 @@
"config" : {
"output" : {
"code" : [
"import ch.ivyteam.ivy.workflow.INote;",
"import ch.ivyteam.ivy.workflow.note.Note;",
"StringBuffer sb = new StringBuffer();",
"for(INote note: ivy.case.getNotes())",
"for(Note note: ivy.case.notes().all())",
"{",
" sb.append(note.getCreationTimestamp());",
" sb.append(note.createdAt());",
" sb.append(\" \");",
" sb.append(note.getWritterName());",
" sb.append(note.authorName());",
" sb.append(\": \");",
" sb.append(note.getMessage());",
" sb.append(note.content());",
" sb.append(\"<br>\");",
"} ",
"",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -186,10 +186,7 @@
"out" : "in",
"out.accepted" : "true"
},
"code" : [
"import ch.ivyteam.ivy.process.model.value.SignalCode;",
"ivy.wf.signals().send(new SignalCode(\"dynamic\"), in);"
]
"code" : "ivy.wf.signals().create().data(in).send(\"dynamic\");"
}
},
"visual" : {
Expand Down Expand Up @@ -306,10 +303,7 @@
"out" : "in",
"out.accepted" : "false"
},
"code" : [
"import ch.ivyteam.ivy.process.model.value.SignalCode;",
"ivy.wf.signals().send(new SignalCode(\"dynamic:cancel\"), in);"
]
"code" : "ivy.wf.signals().create().data(in).send(\"dynamic:cancel\");"
}
},
"visual" : {
Expand Down
9 changes: 4 additions & 5 deletions workflow/workflow-demos/processes/Signal/NewEmployee.p.json
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@
},
"visual" : {
"at" : { "x" : 256, "y" : 512 },
"labelOffset" : { "x" : 11, "y" : 9 }
"labelOffset" : { "x" : 89, "y" : 25 }
},
"connect" : [
{ "id" : "f22", "to" : "f21", "via" : [ { "x" : 256, "y" : 576 } ] }
Expand Down Expand Up @@ -188,7 +188,7 @@
},
"visual" : {
"at" : { "x" : 256, "y" : 320 },
"labelOffset" : { "x" : 11, "y" : 7 }
"labelOffset" : { "x" : 89, "y" : 25 }
},
"connect" : [
{ "id" : "f20", "to" : "f19", "via" : [ { "x" : 256, "y" : 384 } ] }
Expand Down Expand Up @@ -291,16 +291,15 @@
"output" : {
"code" : [
"import com.google.gson.Gson;",
"import ch.ivyteam.ivy.process.model.value.SignalCode;",
"",
"ivy.case.getBusinessCase().setName(\"3.1: New Employee: \" + in.user.name + \" [\" + in.user.userKey + \"]\");",
"",
"// send signal with json payload",
"String jsonSerializedPayload = new Gson().toJson(in.user);",
"ivy.wf.signals().send(new SignalCode(\"user:created\"), jsonSerializedPayload);",
"ivy.wf.signals().create().data(jsonSerializedPayload).send(\"user:created\");",
"",
"// send signal with data class payload (only applicable within same project or dependent projects)",
"ivy.wf.signals().send(new SignalCode(\"user:createdV2\"), in.user);"
"ivy.wf.signals().create().data(in.user).send(\"user:createdV2\");"
]
},
"sudo" : true
Expand Down
4 changes: 2 additions & 2 deletions workflow/workflow-demos/processes/Signal/QuitEmployee.p.json
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,10 @@
"String jsonSerializedPayload = new Gson().toJson(in.quitUserEvent);",
"",
"// send signal",
"ivy.wf.signals().send(signalCode, jsonSerializedPayload);",
"ivy.wf.signals().create().data(jsonSerializedPayload).send(signalCode);",
"",
"// send signal with data class payload (only applicable within same project or dependent projects)",
"ivy.wf.signals().send(new SignalCode(\"admin:quitV2:\" + in.quitUserEvent.userKey), in.quitUserEvent);"
"ivy.wf.signals().create().data(in.quitUserEvent).send(new SignalCode(\"admin:quitV2:\" + in.quitUserEvent.userKey));"
]
}
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,10 @@
"modifiers" : [ "PERSISTENT" ]
}, {
"name" : "userList",
"type" : "List<ch.ivyteam.ivy.security.IUser>",
"modifiers" : [ "PERSISTENT" ]
"type" : "List<ch.ivyteam.ivy.security.IUser>"
}, {
"name" : "userSelection",
"type" : "List<ch.ivyteam.ivy.security.IUser>",
"modifiers" : [ "PERSISTENT" ]
"type" : "List<ch.ivyteam.ivy.security.IUser>"
}, {
"name" : "taskDescription",
"type" : "String",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@
"modifiers" : [ "PERSISTENT" ]
}, {
"name" : "caseNotes",
"type" : "List<ch.ivyteam.ivy.workflow.INote>",
"modifiers" : [ "PERSISTENT" ]
"type" : "List<ch.ivyteam.ivy.workflow.INote>"
}, {
"name" : "addTask",
"type" : "workflow.agileBPM.TaskDef",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
"isBusinessCaseData" : false,
"fields" : [ {
"name" : "interviewModel",
"type" : "ch.ivyteam.ivy.wfdemo.businessdata.InterviewLazyDataModel",
"modifiers" : [ "PERSISTENT" ]
"type" : "ch.ivyteam.ivy.wfdemo.businessdata.InterviewLazyDataModel"
} ]
}
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@
"modifiers" : [ "PERSISTENT" ]
}, {
"name" : "searchResult",
"type" : "ch.ivyteam.ivy.business.data.store.search.Result",
"modifiers" : [ "PERSISTENT" ]
"type" : "ch.ivyteam.ivy.business.data.store.search.Result"
}, {
"name" : "limit",
"type" : "Number",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
"isBusinessCaseData" : false,
"fields" : [ {
"name" : "dossierModel",
"type" : "ch.ivyteam.ivy.wfdemo.businessdata.DossierLazyDataModel",
"modifiers" : [ "PERSISTENT" ]
"type" : "ch.ivyteam.ivy.wfdemo.businessdata.DossierLazyDataModel"
} ]
}
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
"modifiers" : [ "PERSISTENT" ]
}, {
"name" : "cases",
"type" : "List<ch.ivyteam.ivy.workflow.ICase>",
"modifiers" : [ "PERSISTENT" ]
"type" : "List<ch.ivyteam.ivy.workflow.ICase>"
} ]
}

0 comments on commit 5aea164

Please sign in to comment.