Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better pat tyck #1268

Merged
merged 22 commits into from
Jan 4, 2025
Merged

Better pat tyck #1268

merged 22 commits into from
Jan 4, 2025

Conversation

ice1000
Copy link
Member

@ice1000 ice1000 commented Jan 4, 2025

@ice1000 ice1000 added refactoring tyck: pattern Pattern type checking labels Jan 4, 2025
@ice1000 ice1000 added this to the v0.37 milestone Jan 4, 2025
@ice1000 ice1000 marked this pull request as ready for review January 4, 2025 11:55
Copy link

codecov bot commented Jan 4, 2025

Codecov Report

Attention: Patch coverage is 92.24138% with 18 lines in your changes missing coverage. Please review.

Project coverage is 82.96%. Comparing base (ba6e5d3) to head (df382d5).
Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
.../java/org/aya/tyck/pat/iter/SignatureIterator.java 83.87% 2 Missing and 3 partials ⚠️
.../src/main/java/org/aya/tyck/pat/PatternTycker.java 94.73% 0 Missing and 3 partials ⚠️
...main/java/org/aya/tyck/pat/iter/LambdaPusheen.java 85.71% 0 Missing and 2 partials ⚠️
...c/main/java/org/aya/tyck/pat/iter/Pusheenable.java 50.00% 2 Missing ⚠️
...c/main/java/org/aya/syntax/core/pat/PatToTerm.java 83.33% 1 Missing and 1 partial ⚠️
...in/java/org/aya/tyck/pat/iter/PatternIterator.java 88.88% 0 Missing and 1 partial ⚠️
...src/main/java/org/aya/tyck/pat/iter/PiPusheen.java 91.66% 1 Missing ⚠️
...in/java/org/aya/tyck/pat/iter/PusheenIterator.java 95.23% 0 Missing and 1 partial ⚠️
...c/main/java/org/aya/prettier/ConcretePrettier.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1268      +/-   ##
============================================
+ Coverage     82.83%   82.96%   +0.13%     
- Complexity     3992     4051      +59     
============================================
  Files           366      372       +6     
  Lines         11760    11860     +100     
  Branches       1369     1373       +4     
============================================
+ Hits           9741     9840      +99     
+ Misses         1293     1292       -1     
- Partials        726      728       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ice1000 ice1000 merged commit 874b2ac into main Jan 4, 2025
6 checks passed
@ice1000 ice1000 deleted the better-pat-tyck branch January 4, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring tyck: pattern Pattern type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants