Merge pull request #52 from ufrshubham/avoid_copies

Avoid Copies.
ayaankhan98 · Oct 9, 2020 · 4f4daa5 · 4f4daa5
2 parents 183105f + 8e8620d
commit 4f4daa5
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 17 deletions.
diff --git a/big-int/src/bigint.cpp b/big-int/src/bigint.cpp
@@ -66,7 +66,7 @@ largeInt::largeInt(long long nValue)
     this->number = std::to_string(nValue);
 }
 
-largeInt::largeInt(std::string nValue)
+largeInt::largeInt(const std::string& nValue)
 {
     // checks if input string starts with a minus and initializes object with input
     if (nValue.front() == '-')

diff --git a/big-int/src/bigint.hpp b/big-int/src/bigint.hpp
@@ -48,45 +48,45 @@ class largeInt
 
     explicit largeInt(int);
     explicit largeInt(long long int);
-    explicit largeInt(std::string);
+    explicit largeInt(const std::string&);
 
-    largeInt operator+(largeInt);
+    largeInt operator+(const largeInt&);
     largeInt operator+(int);
     largeInt operator+(int64_t);
 
-    largeInt operator-(largeInt);
+    largeInt operator-(const largeInt&);
     largeInt operator-(int);
     largeInt operator-(int64_t);
 
-    largeInt operator*(largeInt);
+    largeInt operator*(const largeInt&);
     largeInt operator*(int);
     largeInt operator*(int64_t);
 
-    largeInt operator/(largeInt);
+    largeInt operator/(const largeInt&);
     largeInt operator/(int);
     largeInt operator/(int64_t);
 
-    largeInt operator%(largeInt);
+    largeInt operator%(const largeInt&);
     largeInt operator%(int);
     largeInt operator%(int64_t);
 
-    largeInt &operator+=(largeInt);
+    largeInt &operator+=(const largeInt&);
     largeInt &operator+=(int);
     largeInt &operator+=(int64_t);
 
-    largeInt &operator-=(largeInt);
+    largeInt &operator-=(const largeInt&);
     largeInt &operator-=(int);
     largeInt &operator-=(int64_t);
 
-    largeInt &operator*=(largeInt);
+    largeInt &operator*=(const largeInt&);
     largeInt &operator*=(int);
     largeInt &operator*=(int64_t);
 
-    largeInt &operator/=(largeInt);
+    largeInt &operator/=(const largeInt&);
     largeInt &operator/=(int);
     largeInt &operator/=(int64_t);
 
-    largeInt operator%=(largeInt);
+    largeInt operator%=(const largeInt&);
     largeInt operator%=(int);
     largeInt operator%=(int64_t);
 
@@ -102,23 +102,23 @@ class largeInt
     bool operator==(int);
     bool operator==(int64_t);
 
-    bool operator!=(largeInt);
+    bool operator!=(const largeInt&);
     bool operator!=(int);
     bool operator!=(int64_t);
 
-    bool operator<(largeInt);
+    bool operator<(const largeInt&);
     bool operator<(int);
     bool operator<(int64_t);
 
-    bool operator>(largeInt);
+    bool operator>(const largeInt&);
     bool operator>(int);
     bool operator>(int64_t);
 
-    bool operator<=(largeInt);
+    bool operator<=(const largeInt&);
     bool operator<=(int);
     bool operator<=(int64_t);
 
-    bool operator>=(largeInt);
+    bool operator>=(const largeInt&);
     bool operator>=(int);
     bool operator>=(int64_t);