[test & fix] ostream, assignment operator #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayaankhan98
reviewed
Oct 5, 2020
ayaankhan98
reviewed
Oct 5, 2020
ayaankhan98
reviewed
Oct 5, 2020
ayaankhan98
reviewed
Oct 5, 2020
There was a problem hiding this comment.
@vladpirlog Thanks for your contribution, please have a look at few suggestions
|
project structure is reconfigured and automated test and build process is also enabled now, please resolve the merge conflicts |
|
@vladpirlog tests for ostream operator are not correctly working |
ayaankhan98
reviewed
Oct 5, 2020
ayaankhan98
reviewed
Oct 5, 2020
ayaankhan98
reviewed
Oct 5, 2020
ayaankhan98
approved these changes
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to [feat] ostream overload with tests #3 [feat] operator overloads #4
added file for constructors
overloaded the assignment operator
made small changes to the implementation of << and >> operators
added tests for ostream operator