Added test for istream. #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayaankhan98
reviewed
Oct 9, 2020
ayaankhan98
reviewed
Oct 9, 2020
|
That example was kind of confusing, but finally I understood what you were saying. Submitted #57 to add try-catch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Adding test for istream operator. Additionally also changes the input.txt for ostream and istream to have all the input cases separated by comma. Having each input on new line was causing file read to pick up the '\r' character as well. And as of now largeInt cannot handle invalid strings as input to constructor. So to avoid additional string manipulation, I have using comma as a delimited for inputs.
Also changed file(COPY) to just copy input.txt file without creating input.txt directory.
Checklist
Notes: Fixes #54 and #1