fix: Remove Crimson as basic color (#450)

* fix: Remove Crimson as basic color * chore: Update all dev packages
ayonious · Jul 2, 2023 · ec89482 · ec89482
1 parent 6348031
commit ec89482
Show file tree

Hide file tree

Showing 25 changed files with 2,056 additions and 1,849 deletions.
diff --git a/package.json b/package.json
@@ -25,24 +25,24 @@
   "author": "Nahiyan Kamal",
   "license": "MIT",
   "devDependencies": {
-    "@semantic-release/changelog": "^6.0.2",
+    "@semantic-release/changelog": "^6.0.3",
     "@semantic-release/git": "^10.0.1",
-    "@types/jest": "^29.4.0",
-    "@typescript-eslint/eslint-plugin": "^5.53.0",
-    "@typescript-eslint/parser": "^5.53.0",
+    "@types/jest": "^29.5.2",
+    "@typescript-eslint/eslint-plugin": "^5.60.1",
+    "@typescript-eslint/parser": "^5.60.1",
     "chalk": "^4.1.2",
-    "eslint": "^8.34.0",
+    "eslint": "^8.44.0",
     "eslint-config-airbnb-base": "^15.0.0",
-    "eslint-config-prettier": "^8.6.0",
+    "eslint-config-prettier": "^8.8.0",
     "eslint-plugin-import": "^2.27.5",
     "eslint-plugin-prettier": "^4.2.1",
     "husky": "^8.0.3",
-    "jest": "^29.4.3",
-    "prettier": "^2.8.4",
+    "jest": "^29.5.0",
+    "prettier": "^2.8.8",
     "pretty-quick": "^3.1.3",
-    "semantic-release": "^20.1.0",
-    "ts-jest": "^29.0.5",
-    "typescript": "^4.9.5"
+    "semantic-release": "^21.0.6",
+    "ts-jest": "^29.1.1",
+    "typescript": "^5.1.6"
   },
   "homepage": "https://console-table.netlify.app",
   "dependencies": {

diff --git a/src/utils/colored-console-line.ts b/src/utils/colored-console-line.ts
@@ -12,7 +12,6 @@ export const DEFAULT_COLOR_MAP: ColorMap = {
   magenta: '\x1b[35m',
   cyan: '\x1b[36m',
   white: '\x1b[37m',
-  crimson: '\x1b[38m',
   white_bold: '\x1b[01m',
   reset: '\x1b[0m',
 };

diff --git a/src/utils/table-constants.ts b/src/utils/table-constants.ts
@@ -50,7 +50,6 @@ export const COLORS = [
   'blue',
   'magenta',
   'cyan',
-  'crimson',
   'white_bold',
   'reset',
 ];

diff --git a/test/__snapshots__/alignment.test.ts.snap b/test/__snapshots__/alignment.test.ts.snap
@@ -8,7 +8,6 @@ exports[`Testing column alignment all kind of alignments are working 1`] = `
 │[37m [0m[31m3                   [0m │[37m [0m[31m       I would like some red wine please[0m │[37m [0m[32m      10.212      [0m │
 │[37m [0m[31m4                   [0m │[37m [0m[36m      I would like some cyan wine please[0m │[37m [0m[32m      10.212      [0m │
 │[37m [0m[31m5                   [0m │[37m [0m[01mI would like some white_bold wine please[0m │[37m [0m[32m      10.212      [0m │
-│[37m [0m[31m6                   [0m │[37m [0m[38m    I would like some crimson sky please[0m │[37m [0m[32m      10.212      [0m │
 │[37m [0m[31m7                   [0m │[37m [0m[32m   I would like some green gemuse please[0m │[37m [0m[32m        20        [0m │
 │[37m [0m[31m8                   [0m │[37m [0m[33m    I would like some gelb bananen bitte[0m │[37m [0m[32m       100        [0m │
 └──────────────────────┴──────────────────────────────────────────┴────────────────────┘"

diff --git a/test/__snapshots__/cellColor.test.ts.snap b/test/__snapshots__/cellColor.test.ts.snap
@@ -1,6 +1,6 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`Example: Print a simple Table with cell colors cell colors are working 1`] = `
+exports[`Example: Print a simple Table with cell colors cell colors are working: ++++Might Fail on CI++++++++ 1`] = `
 "┌───────┬─────────┬────────┐
 │[37m [0m[01mindex[0m │[37m [0m[01m   text[0m │[37m [0m[01m value[0m │
 ├───────┼─────────┼────────┤

diff --git a/test/__snapshots__/columnColor.test.ts.snap b/test/__snapshots__/columnColor.test.ts.snap
@@ -8,7 +8,6 @@ exports[`Example: Print a simple Table with column colors column colors are work
 │[37m [0m[31m3                   [0m │[37m [0m[31m       I would like some red wine please[0m │[37m [0m[32m     10.212[0m │
 │[37m [0m[31m4                   [0m │[37m [0m[36m      I would like some cyan wine please[0m │[37m [0m[32m     10.212[0m │
 │[37m [0m[31m5                   [0m │[37m [0m[01mI would like some white_bold wine please[0m │[37m [0m[32m     10.212[0m │
-│[37m [0m[31m6                   [0m │[37m [0m[38m    I would like some crimson sky please[0m │[37m [0m[32m     10.212[0m │
 │[37m [0m[31m7                   [0m │[37m [0m[32m   I would like some green gemuse please[0m │[37m [0m[32m         20[0m │
 │[37m [0m[31m8                   [0m │[37m [0m[33m    I would like some gelb bananen bitte[0m │[37m [0m[32m        100[0m │
 └──────────────────────┴──────────────────────────────────────────┴─────────────┘"

diff --git a/test/__snapshots__/lineWidthLimit.test.ts.snap b/test/__snapshots__/lineWidthLimit.test.ts.snap
@@ -63,9 +63,6 @@ exports[`Testing column max Width Simple Line Limit 1`] = `
 │[37m [0m[31m5                   [0m │[37m [0m[01m    I would like[0m │[37m [0m[32m10.212[0m │
 │[37m [0m[31m                    [0m │[37m [0m[01m some white_bold[0m │[37m [0m[32m      [0m │
 │[37m [0m[31m                    [0m │[37m [0m[01m     wine please[0m │[37m [0m[32m      [0m │
-│[37m [0m[31m6                   [0m │[37m [0m[38m    I would like[0m │[37m [0m[32m10.212[0m │
-│[37m [0m[31m                    [0m │[37m [0m[38msome crimson sky[0m │[37m [0m[32m      [0m │
-│[37m [0m[31m                    [0m │[37m [0m[38m          please[0m │[37m [0m[32m      [0m │
 │[37m [0m[31m7                   [0m │[37m [0m[32m    I would like[0m │[37m [0m[32m  20  [0m │
 │[37m [0m[31m                    [0m │[37m [0m[32m      some green[0m │[37m [0m[32m      [0m │
 │[37m [0m[31m                    [0m │[37m [0m[32m   gemuse please[0m │[37m [0m[32m      [0m │

diff --git a/test/alignment.test.ts b/test/alignment.test.ts
@@ -44,14 +44,6 @@ describe('Testing column alignment', () => {
       },
       { color: 'white_bold' }
     );
-    p.addRow(
-      {
-        red_left_align_index: 6,
-        right_align_text: 'I would like some crimson sky please',
-        green_value_center: 10.212,
-      },
-      { color: 'crimson' }
-    );
     p.addRow(
       {
         red_left_align_index: 7,

diff --git a/test/cellColor.test.ts b/test/cellColor.test.ts
@@ -2,7 +2,7 @@ import chalk from 'chalk';
 import { Table } from '../index';
 
 describe('Example: Print a simple Table with cell colors', () => {
-  it('cell colors are working', () => {
+  it('cell colors are working: ++++Might Fail on CI++++++++', () => {
     // Create a table
     const p = new Table();
 

diff --git a/test/columnColor.test.ts b/test/columnColor.test.ts
@@ -44,14 +44,6 @@ describe('Example: Print a simple Table with column colors', () => {
       },
       { color: 'white_bold' }
     );
-    p.addRow(
-      {
-        red_left_align_index: 6,
-        right_align_text: 'I would like some crimson sky please',
-        green_value: 10.212,
-      },
-      { color: 'crimson' }
-    );
     p.addRow(
       {
         red_left_align_index: 7,

diff --git a/test/internalTable/__snapshots__/alignment.test.ts.snap b/test/internalTable/__snapshots__/alignment.test.ts.snap
@@ -8,7 +8,6 @@ exports[`Testing column alignment all kind of alignments are working 1`] = `
 │[37m [0m[31m3                   [0m │[37m [0m[31m       I would like some red wine please[0m │[37m [0m[32m      10.212      [0m │
 │[37m [0m[31m4                   [0m │[37m [0m[36m      I would like some cyan wine please[0m │[37m [0m[32m      10.212      [0m │
 │[37m [0m[31m5                   [0m │[37m [0m[01mI would like some white_bold wine please[0m │[37m [0m[32m      10.212      [0m │
-│[37m [0m[31m6                   [0m │[37m [0m[38m    I would like some crimson sky please[0m │[37m [0m[32m      10.212      [0m │
 │[37m [0m[31m7                   [0m │[37m [0m[32m   I would like some green gemuse please[0m │[37m [0m[32m        20        [0m │
 │[37m [0m[31m8                   [0m │[37m [0m[33m    I would like some gelb bananen bitte[0m │[37m [0m[32m       100        [0m │
 └──────────────────────┴──────────────────────────────────────────┴────────────────────┘"

diff --git a/test/internalTable/__snapshots__/columnColor.test.ts.snap b/test/internalTable/__snapshots__/columnColor.test.ts.snap
@@ -8,7 +8,7 @@ exports[`Example: Print a simple Table with column colors column colors are work
 │[37m [0m[31m3                   [0m │[37m [0m[31m       I would like some red wine please[0m │[37m [0m[32m     10.212[0m │
 │[37m [0m[31m4                   [0m │[37m [0m[36m      I would like some cyan wine please[0m │[37m [0m[32m     10.212[0m │
 │[37m [0m[31m5                   [0m │[37m [0m[01mI would like some white_bold wine please[0m │[37m [0m[32m     10.212[0m │
-│[37m [0m[31m6                   [0m │[37m [0m[38m    I would like some crimson sky please[0m │[37m [0m[32m     10.212[0m │
+│[37m [0m[31m6                   [0m │[37m [0m[37m    I would like some crimson sky please[0m │[37m [0m[32m     10.212[0m │
 │[37m [0m[31m7                   [0m │[37m [0m[32m   I would like some green gemuse please[0m │[37m [0m[32m         20[0m │
 │[37m [0m[31m8                   [0m │[37m [0m[33m    I would like some gelb bananen bitte[0m │[37m [0m[32m        100[0m │
 └──────────────────────┴──────────────────────────────────────────┴─────────────┘"

diff --git a/test/internalTable/__snapshots__/enableDisable.test.ts.snap b/test/internalTable/__snapshots__/enableDisable.test.ts.snap
@@ -8,7 +8,7 @@ exports[`Testing column Enable and Disable disable basic example 1`] = `
 │[37m [0m[31m            10.212[0m │
 │[37m [0m[36m            10.212[0m │
 │[37m [0m[01m            10.212[0m │
-│[37m [0m[38m            10.212[0m │
+│[37m [0m[37m            10.212[0m │
 │[37m [0m[32m                20[0m │
 │[37m [0m[33m               100[0m │
 └────────────────────┘"
@@ -22,7 +22,7 @@ exports[`Testing column Enable and Disable enable basic example 1`] = `
 │[37m [0m[31m                   3[0m │[37m [0m[31m       I would like some red wine please[0m │
 │[37m [0m[36m                   4[0m │[37m [0m[36m      I would like some cyan wine please[0m │
 │[37m [0m[01m                   5[0m │[37m [0m[01mI would like some white_bold wine please[0m │
-│[37m [0m[38m                   6[0m │[37m [0m[38m    I would like some crimson sky please[0m │
+│[37m [0m[37m                   6[0m │[37m [0m[37m    I would like some crimson sky please[0m │
 │[37m [0m[32m                   7[0m │[37m [0m[32m   I would like some green gemuse please[0m │
 │[37m [0m[33m                   8[0m │[37m [0m[33m    I would like some gelb bananen bitte[0m │
 └──────────────────────┴──────────────────────────────────────────┘"

diff --git a/test/internalTable/__snapshots__/sorting.test.ts.snap b/test/internalTable/__snapshots__/sorting.test.ts.snap
@@ -6,7 +6,7 @@ exports[`Testing column alignment all kind of alignments are working 1`] = `
 ├──────────────────────┼──────────────────────────────────────────┼────────────────────┤
 │[37m [0m[33m8                   [0m │[37m [0m[33m    I would like some gelb bananen bitte[0m │[37m [0m[33m       100        [0m │
 │[37m [0m[32m7                   [0m │[37m [0m[32m   I would like some green gemuse please[0m │[37m [0m[32m        20        [0m │
-│[37m [0m[38m6                   [0m │[37m [0m[38m    I would like some crimson sky please[0m │[37m [0m[38m      10.212      [0m │
+│[37m [0m[37m6                   [0m │[37m [0m[37m    I would like some crimson sky please[0m │[37m [0m[37m      10.212      [0m │
 │[37m [0m[01m5                   [0m │[37m [0m[01mI would like some white_bold wine please[0m │[37m [0m[01m      10.212      [0m │
 │[37m [0m[36m4                   [0m │[37m [0m[36m      I would like some cyan wine please[0m │[37m [0m[36m      10.212      [0m │
 │[37m [0m[31m3                   [0m │[37m [0m[31m       I would like some red wine please[0m │[37m [0m[31m      10.212      [0m │

diff --git a/test/internalTable/__snapshots__/title.test.ts.snap b/test/internalTable/__snapshots__/title.test.ts.snap
@@ -20,7 +20,7 @@ exports[`Testing column alignment all kind of alignments are working 1`] = `
 │[37m [0m[31m3                   [0m │[37m [0m[31m       I would like some red wine please[0m │[37m [0m[32m      10.212      [0m │
 │[37m [0m[31m4                   [0m │[37m [0m[36m      I would like some cyan wine please[0m │[37m [0m[32m      10.212      [0m │
 │[37m [0m[31m5                   [0m │[37m [0m[01mI would like some white_bold wine please[0m │[37m [0m[32m      10.212      [0m │
-│[37m [0m[31m6                   [0m │[37m [0m[38m    I would like some crimson sky please[0m │[37m [0m[32m      10.212      [0m │
+│[37m [0m[31m6                   [0m │[37m [0m[37m    I would like some crimson sky please[0m │[37m [0m[32m      10.212      [0m │
 │[37m [0m[31m7                   [0m │[37m [0m[32m   I would like some green gemuse please[0m │[37m [0m[32m        20        [0m │
 │[37m [0m[31m8                   [0m │[37m [0m[33m    I would like some gelb bananen bitte[0m │[37m [0m[32m       100        [0m │
 └──────────────────────┴──────────────────────────────────────────┴────────────────────┘"

diff --git a/test/internalTable/alignment.test.ts b/test/internalTable/alignment.test.ts
@@ -45,14 +45,6 @@ describe('Testing column alignment', () => {
       },
       { color: 'white_bold' }
     );
-    p.addRow(
-      {
-        red_left_align_index: 6,
-        right_align_text: 'I would like some crimson sky please',
-        green_value_center: 10.212,
-      },
-      { color: 'crimson' }
-    );
     p.addRow(
       {
         red_left_align_index: 7,

diff --git a/test/internalTable/columnColor.test.ts b/test/internalTable/columnColor.test.ts
@@ -45,14 +45,11 @@ describe('Example: Print a simple Table with column colors', () => {
       },
       { color: 'white_bold' }
     );
-    p.addRow(
-      {
-        red_left_align_index: 6,
-        right_align_text: 'I would like some crimson sky please',
-        green_value: 10.212,
-      },
-      { color: 'crimson' }
-    );
+    p.addRow({
+      red_left_align_index: 6,
+      right_align_text: 'I would like some crimson sky please',
+      green_value: 10.212,
+    });
     p.addRow(
       {
         red_left_align_index: 7,

diff --git a/test/internalTable/enableDisable.test.ts b/test/internalTable/enableDisable.test.ts
@@ -41,14 +41,11 @@ describe('Testing column Enable and Disable', () => {
       },
       { color: 'white_bold' }
     );
-    p.addRow(
-      {
-        red_left_align_index: 6,
-        right_align_text: 'I would like some crimson sky please',
-        green_value_center: 10.212,
-      },
-      { color: 'crimson' }
-    );
+    p.addRow({
+      red_left_align_index: 6,
+      right_align_text: 'I would like some crimson sky please',
+      green_value_center: 10.212,
+    });
     p.addRow(
       {
         red_left_align_index: 7,
@@ -113,14 +110,11 @@ describe('Testing column Enable and Disable', () => {
       },
       { color: 'white_bold' }
     );
-    p.addRow(
-      {
-        red_left_align_index: 6,
-        right_align_text: 'I would like some crimson sky please',
-        green_value_center: 10.212,
-      },
-      { color: 'crimson' }
-    );
+    p.addRow({
+      red_left_align_index: 6,
+      right_align_text: 'I would like some crimson sky please',
+      green_value_center: 10.212,
+    });
     p.addRow(
       {
         red_left_align_index: 7,

diff --git a/test/internalTable/filter.test.ts b/test/internalTable/filter.test.ts
@@ -46,14 +46,11 @@ describe('Testing column alignment', () => {
       },
       { color: 'white_bold' }
     );
-    p.addRow(
-      {
-        red_left_align_index: 6,
-        right_align_text: 'I would like some crimson sky please',
-        green_value_center: 10.212,
-      },
-      { color: 'crimson' }
-    );
+    p.addRow({
+      red_left_align_index: 6,
+      right_align_text: 'I would like some crimson sky please',
+      green_value_center: 10.212,
+    });
     p.addRow(
       {
         red_left_align_index: 7,

diff --git a/test/internalTable/sorting.test.ts b/test/internalTable/sorting.test.ts
@@ -47,14 +47,11 @@ describe('Testing column alignment', () => {
       },
       { color: 'white_bold' }
     );
-    p.addRow(
-      {
-        red_left_align_index: 6,
-        right_align_text: 'I would like some crimson sky please',
-        green_value_center: 10.212,
-      },
-      { color: 'crimson' }
-    );
+    p.addRow({
+      red_left_align_index: 6,
+      right_align_text: 'I would like some crimson sky please',
+      green_value_center: 10.212,
+    });
     p.addRow(
       {
         red_left_align_index: 7,

diff --git a/test/internalTable/title.test.ts b/test/internalTable/title.test.ts
@@ -46,14 +46,11 @@ describe('Testing column alignment', () => {
       },
       { color: 'white_bold' }
     );
-    p.addRow(
-      {
-        red_left_align_index: 6,
-        right_align_text: 'I would like some crimson sky please',
-        green_value_center: 10.212,
-      },
-      { color: 'crimson' }
-    );
+    p.addRow({
+      red_left_align_index: 6,
+      right_align_text: 'I would like some crimson sky please',
+      green_value_center: 10.212,
+    });
     p.addRow(
       {
         red_left_align_index: 7,

diff --git a/test/lineWidthLimit.test.ts b/test/lineWidthLimit.test.ts
@@ -44,14 +44,6 @@ describe('Testing column max Width', () => {
       },
       { color: 'white_bold' }
     );
-    p.addRow(
-      {
-        red_left_align_index: 6,
-        right_align_text: 'I would like some crimson sky please',
-        green: 10.212,
-      },
-      { color: 'crimson' }
-    );
     p.addRow(
       {
         red_left_align_index: 7,

diff --git a/test/readme/readmeExamples1.test.ts b/test/readme/readmeExamples1.test.ts
@@ -84,7 +84,40 @@ describe('Example: 1', () => {
       { color: 'white_bold' }
     );
     p.addRow(
-      { index: 6, text: 'I would like some crimson sky please', value: 10.212 },
+      { index: 7, text: 'I would like some green gemuse please', value: 20.0 },
+      { color: 'green' }
+    );
+    p.addRow(
+      { index: 8, text: 'I would like some gelb bananen bitte', value: 100 },
+      { color: 'yellow' }
+    );
+
+    // print
+    const returned = p.printTable();
+    expect(returned).toBeUndefined();
+  });
+
+  it('table With all colored rows', () => {
+    // Create a table
+    const p = new Table({
+      columns: [
+        { name: 'index', alignment: 'left' },
+        { name: 'text', alignment: 'right' },
+        { name: 'value' },
+      ],
+    });
+
+    // add rows with color
+    p.addRow(
+      { index: 2, text: 'I would like some Color I dont know', value: 10.212 },
+      { color: 'some Color' }
+    );
+    p.addRow(
+      {
+        index: 6,
+        text: 'I would like some crimson I dont know the color sky please',
+        value: 10.212,
+      },
       { color: 'crimson' }
     );
     p.addRow(

diff --git a/test/render.test.ts b/test/render.test.ts
@@ -44,14 +44,11 @@ describe('Testing rendering column alignment', () => {
       },
       { color: 'white_bold' }
     );
-    p.addRow(
-      {
-        red_left_align_index: 6,
-        right_align_text: 'I would like some crimson sky please',
-        green_value_center: 10.212,
-      },
-      { color: 'crimson' }
-    );
+    p.addRow({
+      red_left_align_index: 6,
+      right_align_text: 'I would like some crimson sky please',
+      green_value_center: 10.212,
+    });
     p.addRow(
       {
         red_left_align_index: 7,