feat: The Computed Column function is passed row
, index
, and array
#464
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👀What is this pr about?
The Computed Column function is passed
row
,index
, andarray
. The latter two are new.I modeled this change on JavaScript's
map()
callback parameter.🚀 Changes
Before:
After:
array
is astring[]
. I'm not sure why anything in this file has anany
type, but I used it here to follow conventions.Along the way, I noticed that the
addColumn
andaddColumns
parameters may have the wrong types?Related
table.addColumn
andtable.addColumns
have incorrect type signatures. #462any
types in typescript files #463