Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix platformio_upload.py for SPIFFS #202

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

marcelrv
Copy link

Allows the script to upload files system images

Allows the script to upload files system images
Copy link

@lostMia lostMia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly for me!

@freman
Copy link

freman commented Jul 3, 2024

Might I suggest a slightly different approach.

I'm not sure when this became a default but my envs all have "Upload Filesystem Image OTA" as a task now, this task target is called "uploadfsota" - this would seem to work with that configuration regardless of if it's spiffs or littlefs

        urlMode = "fs" if str(target[0]) == "uploadfsota" else "fr"

        # Führe die GET-Anfrage aus
        start_url = f"{upload_url}/ota/start?mode={urlMode}&hash={md5}"

@marcelrv
Copy link
Author

marcelrv commented Jul 8, 2024

Might I suggest a slightly different approach.

I'm not sure when this became a default but my envs all have "Upload Filesystem Image OTA" as a task now, this task target is called "uploadfsota" - this would seem to work with that configuration regardless of if it's spiffs or littlefs

        urlMode = "fs" if str(target[0]) == "uploadfsota" else "fr"

        # Führe die GET-Anfrage aus
        start_url = f"{upload_url}/ota/start?mode={urlMode}&hash={md5}"

yes, that would work, but indeed I did not chose that way as there are 2 filesystem uploads.
The non-ota one does not work if the custom script is there. Hence by using the file name based approach both filesystem uploads are working.

@freman
Copy link

freman commented Jul 8, 2024

oh, I didn't encounter that, I keep my ota and non-ota in seperate envs.

Copy link
Contributor

github-actions bot commented Aug 8, 2024

This PR is marked as stale because it has been open 45 days with no activity. You can remove stale label or comment if this PR is still valid.

@github-actions github-actions bot added the Stale label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants