-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #3756: Add default “no results” text on all the News views #3760
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be a lot of extraneous changes in the current PR. It should probably be cleaned up to just have the relevant changes.
At the moment, I'm not sure what this PR really changes. On a current standard install of AZQS, the /news page already has the "No results" messaging.
Looking at /admin/structure/views/view/az_news on the Probo build, most displays still don't have a "No results behavior" added (Feature View, Grid View with Filter, Small Row View, Teaser Grid Page, Recent News Marquee, Row Attachment).
Considering the wording that already exists on Paged Row View and Grid View, I think the message could be improved. This PR could be a fine place to update it.
As a user, the wording "No results found for the applied filters." is confusing. It makes me think I did something wrong, like I applied some hidden filters without knowing it when all I did was look at a page with the news grid or navigate to /news. There aren't even any filters that I can change as a user to alleviate the issue with the "applied filters."
I would suggest updating the wording to be similar to Events when there are no events.
Examples:
- There are no news items.
- There are no news items listed.
- There is currently no news.
- There is no news listed.
@ejsamboy good choice for wording! Looks like more will need updating. Probo demo site shows: |
I rebuilt the probo site to see if the default changes all went through. |
It looks like the changes were not applied as expected on the probo build. And it's due to the finder functionality overriding the News view display. To remedy this, please modify the following file to the following code in addition to what you have changed already. modules/custom/az_finder/config/quickstart/views.view.az_news.yml Open for code block of entire file
|
Co-authored-by: Dana Hertzberg <[email protected]>
modules/custom/az_news/config/install/core.entity_view_display.node.az_news.az_row.yml
Outdated
Show resolved
Hide resolved
….node.az_news.az_row.yml
….node.az_news.az_row.yml
modules/custom/az_news/config/install/core.entity_view_display.node.az_news.az_row.yml
Outdated
Show resolved
Hide resolved
….node.az_news.az_row.yml
modules/custom/az_news/config/install/core.entity_view_display.node.az_news.az_row.yml
Outdated
Show resolved
Hide resolved
….node.az_news.az_row.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have applied these changes on a new commit
Description
Add a default "no results" text to all the News views.
Closes: #3756
How to test
If the News has no content, it should show this message:
“There are no news items listed.”
You can test this behavior using the links below. Both should display the same message:
Types of changes
Arizona Quickstart (install profile, custom modules, custom theme)
Drupal core
Drupal contrib projects
Checklist