Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close #3913 Add new content field to publication. #3914

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

trackleft
Copy link
Member

@trackleft trackleft commented Nov 26, 2024

Description

This Pull Request adds a new field and some demo content for the az_publication content type.
The new field has been added as hidden on each existing display mode except for the default display.
The new field has been added to the bottom of the az_publication edit/create form

Related issues

Close #3913

How to test

Create a new publication
Scroll to bottom of publication form and see field labelled page elements.
Add some elements and save the publication.
View how the publication is displayed.

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My change requires release notes.

@trackleft trackleft requested a review from a team as a code owner November 26, 2024 21:55
@trackleft trackleft added patch release Issues to be included in the next patch release publications labels Nov 26, 2024
@trackleft
Copy link
Member Author

It was determined that we should include the new content field as a paragraphs field.

ewlyman
ewlyman previously approved these changes Jan 10, 2025
Copy link
Contributor

@ewlyman ewlyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Field works as designed. All good as far as I can see :)

@trackleft
Copy link
Member Author

Add paragraphs as a dependency of az_publication.

@trackleft
Copy link
Member Author

trackleft commented Jan 10, 2025

Add paragraphs as a dependency of az_publication.

Looks like that dependency already exists: https://github.com/az-digital/az_quickstart/blob/issue/3913-add-content-field-to-az-publication/modules/custom/az_publication/az_publication.info.yml#L35

@bberndt-uaz
Copy link
Contributor

image

For the default display (as shown above), I recommend that we add headings for the Publication File and the Main Content. Also, maybe the Publication File should go directly below the Reference?

@bberndt-uaz
Copy link
Contributor

bberndt-uaz commented Jan 17, 2025

To follow up on a question that came up on Wednesday about the heading text for the main content field: it seems difficult to come up with an appropriate heading that would account for all situations. I think we could make the heading customizable as Cameron suggested as an option or we could skip adding the heading and just add a small amount of extra margin above that field to set it apart from the other content. I still think the Publication File should have a heading or some kind of label--whatever you think is best!

Copy link
Contributor

@bberndt-uaz bberndt-uaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

image

@trackleft
Copy link
Member Author

Use full text for the label instead of publication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch release Issues to be included in the next patch release publications
Projects
Status: Needs review
Development

Successfully merging this pull request may close these issues.

Add a content field to publication in order to allow hosting a journal.
3 participants