Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3922 Add Event to Calendar support #3923

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fixes #3922 Add Event to Calendar support #3923

wants to merge 1 commit into from

Conversation

tadean
Copy link
Contributor

@tadean tadean commented Dec 4, 2024

Description

This Draft PR adds a block that creates add-to-calendar links based upon spatie/calendar-links

Related issues

#3922

How to test

  • Enable az_demo
  • visit /admin/structure/block
  • Place Add to Calendar Block in the content region below Main page content
  • Set the block's Display title to false
  • Set the Content type of block placement to Event
  • Save the block placement
  • view an event
  • Verify the Add Event to Calendar button appears
  • Click the button and attempt to add the event to a calendar

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My change requires release notes.

@tadean tadean added enhancement New feature or request visual change Introduces a visual change usability Improvements to usability of Quickstart components user experience Improvements to user experience proposal Proposed change to how something works (usually larger or more fundamental than a feature request) 2.13.x only labels Dec 4, 2024
@tadean tadean self-assigned this Dec 4, 2024
@tadean
Copy link
Contributor Author

tadean commented Dec 4, 2024

image

@tadean
Copy link
Contributor Author

tadean commented Dec 4, 2024

  • Recurring events?
  • Perhaps a different implementation than Block would be preferred

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.13.x only enhancement New feature or request proposal Proposed change to how something works (usually larger or more fundamental than a feature request) usability Improvements to usability of Quickstart components user experience Improvements to user experience visual change Introduces a visual change
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

1 participant