Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close #3967: Add Masquerade Log module #3970

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ewlyman
Copy link
Contributor

@ewlyman ewlyman commented Jan 7, 2025

Description

Added new line to "require" in composer.json file:
"drupal/masquerade_log" : "^1.2",

Release notes

If this change requires release notes: provide a summary of changes, how to use this change, and any related links. This content will be pasted in the release notes. Use markdown format to ensure proper pasting of information. Release notes example

Make sure to add the release notes label to this PR.

This release adds the module [Masquerade Log](https://www.drupal.org/project/masquerade_log) to Arizona Quickstart. If a site uses the [Masquerade](https://www.drupal.org/project/masquerade) module, Site owners can enable the Masquerade Log module to track when the Masquerade module is used by viewing the Recent log messages report (/admin/reports/dblog)

Related issues

How to test

To Test:

  1. Enable the Masquerade and Masquerade Log modules
  2. Clear site cache
  3. Visit a user account and select "Masquerade as..."
  4. Perform some action on the site while masquerading as another user
  5. Unmasquerade
  6. Review Recent log messages report. You should see the following:
    a. The masquerade event
    b. Actions taken by the masqueraded user
    c. The "stopped masquerading as" event.

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My change requires release notes.

Added new line to "require":
"drupal/masquerade_log" : "^1.2",
@ewlyman ewlyman linked an issue Jan 7, 2025 that may be closed by this pull request
5 tasks
@ewlyman ewlyman self-assigned this Jan 7, 2025
@ewlyman
Copy link
Contributor Author

ewlyman commented Jan 7, 2025

Waiting to check in Probo build.

@ewlyman ewlyman added enhancement New feature or request editor experience Improvements to the editor experience for individuals editing Quickstart websites release notes dependencies Pull requests that update a dependency file proposal Proposed change to how something works (usually larger or more fundamental than a feature request) labels Jan 8, 2025
@ewlyman
Copy link
Contributor Author

ewlyman commented Jan 8, 2025

Screenshot of Recent log messages with Masquerade log enabled:
Screenshot 2025-01-08 at 8 47 31 AM

@ewlyman ewlyman changed the title Update composer.json Close #3967: Add Masquerade Log module Jan 8, 2025
@ewlyman ewlyman marked this pull request as ready for review January 8, 2025 16:40
@ewlyman ewlyman requested a review from a team as a code owner January 8, 2025 16:40
composer.json Outdated Show resolved Hide resolved
@joshuasosa
Copy link
Contributor

Masquerade Log's description in the UI isn't ideal:
image

Perhaps the patch in https://www.drupal.org/project/masquerade_log/issues/3466619 could be added here as well?

@ewlyman ewlyman requested a review from joeparsons January 9, 2025 20:45
@ewlyman ewlyman marked this pull request as draft January 9, 2025 20:53
@ewlyman
Copy link
Contributor Author

ewlyman commented Jan 9, 2025

As maintainers haven't taken action on missing module description for ~6 mos., agree with @joshuasosa
patch added.

@ewlyman
Copy link
Contributor Author

ewlyman commented Jan 9, 2025

Just checked in Probo build. Looks OK.
Maybe try again for review?

@ewlyman ewlyman marked this pull request as ready for review January 9, 2025 22:22
@ewlyman ewlyman marked this pull request as draft January 10, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file editor experience Improvements to the editor experience for individuals editing Quickstart websites enhancement New feature or request proposal Proposed change to how something works (usually larger or more fundamental than a feature request) release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Masquerade Log module
3 participants