-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close #3967: Add Masquerade Log module #3970
Draft
ewlyman
wants to merge
5
commits into
main
Choose a base branch
from
3967-add-masquerade-log-module
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added new line to "require": "drupal/masquerade_log" : "^1.2",
5 tasks
Waiting to check in Probo build. |
ewlyman
added
enhancement
New feature or request
editor experience
Improvements to the editor experience for individuals editing Quickstart websites
release notes
dependencies
Pull requests that update a dependency file
proposal
Proposed change to how something works (usually larger or more fundamental than a feature request)
labels
Jan 8, 2025
joeparsons
reviewed
Jan 8, 2025
Change pins module to specific version. Co-authored-by: Joe Parsons <[email protected]>
Masquerade Log's description in the UI isn't ideal: Perhaps the patch in https://www.drupal.org/project/masquerade_log/issues/3466619 could be added here as well? |
As maintainers haven't taken action on missing module description for ~6 mos., agree with @joshuasosa |
Just checked in Probo build. Looks OK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file
editor experience
Improvements to the editor experience for individuals editing Quickstart websites
enhancement
New feature or request
proposal
Proposed change to how something works (usually larger or more fundamental than a feature request)
release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added new line to "require" in composer.json file:
"drupal/masquerade_log" : "^1.2",
Release notes
If this change requires release notes: provide a summary of changes, how to use this change, and any related links. This content will be pasted in the release notes. Use markdown format to ensure proper pasting of information. Release notes example
Make sure to add the
release notes
label to this PR.Related issues
How to test
To Test:
a. The masquerade event
b. Actions taken by the masqueraded user
c. The "stopped masquerading as" event.
Types of changes
Arizona Quickstart (install profile, custom modules, custom theme)
Drupal core
Drupal contrib projects
Checklist