Remove awscli as a dependency from rastervision_aws_s3 and make it a dev dependency instead
#2220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make it a dev dependency instead
AdeelH
added
the
needs-backport
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2220 +/- ##
=======================================
Coverage 90.34% 90.34%
=======================================
Files 199 199
Lines 9910 9910
=======================================
Hits 8953 8953
Misses 957 957 ☔ View full report in Codecov by Sentry. |
AdeelH
added a commit
to AdeelH/raster-vision
that referenced
this pull request
Aug 29, 2024
make it a dev dependency instead
AdeelH
changed the title
awscli as a dependencyawscli as a dependency from rastervision_aws_s3 and make it a dev dependency instead
AdeelH
added a commit
that referenced
this pull request
Aug 30, 2024
make it a dev dependency instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR removes awscli (v1) as a dependency, so that it doesn't affect users' existing v2 installation.
Checklist
needs-backportlabel if the change should be back-ported to the previous releaseNotes
N/A
Testing Instructions
N/A