fix(Script/BlackTemple) Illidan won't double up on his script actions

[blinkysc]

Changes Proposed:

This PR proposes changes to:

• Core (units, players, creatures, game systems).
• Scripts (bosses, spell scripts, creature scripts).
• Database (SAI, creatures, etc).

Issues Addressed:

• Closes [Black Temple - Illidan] Illidan can double up on his script actions during the last phase transition. #20217

SOURCE:

The changes have been validated through:

• Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
• Sniffs (remember to share them with the open source community!)
• Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
• The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

• Tested in-game by the author.
• Tested in-game by other community members/someone else other than the author/has been live on production servers.
• This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

• This pull request can be tested by following the reproduction steps provided in the linked issue
• This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

1. .go c id 22917
2. .damage 1000000 through phases, until under 30% health
3. Let him heal himself above and then .damage again under 30%

Known Issues and TODO List:

• [ ]
• [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

[Nyeriah]

Were you able to reproduce it after the latest changes done to the HealthCheck scheduler?

[blinkysc]

Were you able to reproduce it after the latest changes done to the HealthCheck scheduler?

Honestly applied my fix and just tested that... Let me try before so can be sure lol

[Nyeriah]

The issue (If still there) isn't in the boss script but a race condition in the healthcheck implementation

[blinkysc]

The issue (If still there) isn't in the boss script but a race condition in the healthcheck implementation

Interesting, maybe then this fix is irrelevant

[Rorschach91]

The issue (If still there) isn't in the boss script but a race condition in the healthcheck implementation

Illidan continues to have problems, but this particular problem I have not seen in months (and I fight Illidan every week).

[blinkysc]

The issue (If still there) isn't in the boss script but a race condition in the healthcheck implementation

Illidan continues to have problems, but this particular problem I have not seen in months (and I fight Illidan every week).

Yeah same thing with original script... So what I did adds nothing I think? Though guess with the bool it would make sure for sure... But that's a bit "hackish" if so

[blinkysc]

Probably fixed then from healthcheck fix?

[Rorschach91]

Probably fixed then from healthcheck fix?

Maybe....Maybe not. This bug is not easy to reproduce, so I cannot confirm that it has been fixed.

[Nyeriah]

Either way if there is an issue it is preferrable if its fixed in the source rather than every boss script that uses healthchecks, thanks for the PR tho 👍

[blinkysc]

Ok cool, I'll close the PR then