Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/federated credentials #1782

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

najvv
Copy link

@najvv najvv commented Aug 28, 2023

Issue-id

PR Checklist


Description

  • support azuread federated credentials and managed identity federated credentials
  • support federated credentials with aks resource
  • fix private endpoint

there is an existing PR #1666 however it does not cover all of use cases. we shall be able to create aks and federated credentials in different landingzones since person who deploy aks may not necessarily have permission to manage ad resources and workload identity shall support both mi and azure app.

Does this introduce a breaking change

  • YES
  • NO

Testing

examples are added

Copy link
Contributor

@LaurentLesle LaurentLesle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @najvv for submitting the PR. I have added some comments on the examples you have provided. Can you address them and will continue the review.

@najvv
Copy link
Author

najvv commented Aug 29, 2023

@LaurentLesle updated examples and included in worklows

@arnaudlh arnaudlh added the enhancement New feature or request label Sep 6, 2023
@arnaudlh arnaudlh added this to the 5.7.4 milestone Sep 6, 2023
@arnaudlh arnaudlh removed this from the 5.7.4 milestone Sep 29, 2023
@arne21a
Copy link
Contributor

arne21a commented Nov 2, 2023

Thanks for the PR, we need federated credentials for our gitlab ci/cd integration.
@LaurentLesle: When will this be merged

@toniiiik
Copy link

toniiiik commented Mar 1, 2024

Hello @LaurentLesle, when do you think this could be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

5 participants