-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/federated credentials #1782
base: main
Are you sure you want to change the base?
Conversation
- fix private endpoint in aks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @najvv for submitting the PR. I have added some comments on the examples you have provided. Can you address them and will continue the review.
examples/compute/kubernetes_services/109-single-cluster-federated-credentials/aks.tfvars
Show resolved
Hide resolved
@LaurentLesle updated examples and included in worklows |
Thanks for the PR, we need federated credentials for our gitlab ci/cd integration. |
Hello @LaurentLesle, when do you think this could be merged? |
Issue-id
PR Checklist
Description
there is an existing PR #1666 however it does not cover all of use cases. we shall be able to create aks and federated credentials in different landingzones since person who deploy aks may not necessarily have permission to manage ad resources and workload identity shall support both mi and azure app.
Does this introduce a breaking change
Testing
examples are added