Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation, e.g. fix typos #281

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Conversation

headcr4sh
Copy link
Contributor

@headcr4sh headcr4sh commented Apr 4, 2024

Issue-id

PR Checklist


  • I have read the CONTRIBUTING.MD instructions
  • I have changed the resourceDefinition.json
  • I have generated the resource model (there's a models_generated.go file in my PR)
  • I have updated the README.md#resource-status
  • I have checked to ensure there aren't other open Pull Requests for the same update/change?

Description

Does this introduce a breaking change

  • YES
  • NO

Testing

@headcr4sh headcr4sh changed the title Fix minor typo in documentation. Improve documentation, e.g. fix typos Apr 4, 2024
Also:
- Format example code according to what  `terraform fmt` would produce.
- Remove `bash` formatting instruction from example script *outputs* that
  don't qualify as bash scripts themselves.
Copy link
Member

@arnaudlh arnaudlh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the contribution @headcr4sh

@arnaudlh arnaudlh added the documentation Improvements or additions to documentation label Apr 10, 2024
@arnaudlh arnaudlh added this to the 1.2.29 milestone Apr 10, 2024
Copy link

sonarcloud bot commented Apr 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@arnaudlh arnaudlh merged commit bbd26cc into aztfmod:main Apr 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants