Skip to content
This repository has been archived by the owner on Jul 30, 2024. It is now read-only.

refactor!: remove not core modules #1

Merged
merged 13 commits into from
Jul 26, 2024

Conversation

dongsam
Copy link
Member

@dongsam dongsam commented Jul 24, 2024

Description

Remove Canto Additional Ethermint Dependent Modules

  • CSR

Remove IBC Modules

  • IBC
  • Transfer

Remove Cosmos SDK Optional Modules

  • Authz

Remove Canto Additional Ethermint/IBC Dependent Modules

  • Onboarding
  • Coinswap

TODO

  • re-generation proto, *.pb.go, Swagger
  • check simulations

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • included the necessary unit and integration tests
  • reviewed "Files changed" and left comments if necessary

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@dongsam dongsam requested a review from jasonsong0 July 24, 2024 02:23
Copy link

@jasonsong0 jasonsong0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from a comment above.
Is client doc automatically generated? If not, it seems better to delete the docs for deleted modules

x/erc20/types/msg.go Show resolved Hide resolved
@dongsam dongsam requested a review from jasonsong0 July 25, 2024 08:08
Copy link

@jasonsong0 jasonsong0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dongsam dongsam self-assigned this Jul 26, 2024
@dongsam dongsam added this to the Phase 1.0 The BaseChain milestone Jul 26, 2024
@dongsam dongsam marked this pull request as ready for review July 26, 2024 05:37
@dongsam dongsam merged commit febe40a into abci1.0/develop Jul 26, 2024
8 checks passed
@dongsam dongsam requested a review from zsystm July 29, 2024 01:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants